summaryrefslogtreecommitdiffstats
path: root/flashchips.c
diff options
context:
space:
mode:
authorStefan Tauner <stefan.tauner@alumni.tuwien.ac.at>2014-07-13 12:52:15 +0000
committerStefan Tauner <stefan.tauner@alumni.tuwien.ac.at>2014-07-13 12:52:15 +0000
commit78ea7814ff3e4ae9ac9454fcbd4df6efd13708fd (patch)
treea2e8e2fd20756392fe86c8154dc610672c8e4f2d /flashchips.c
parent604649a30c10b25833ac49a8b215674f233a8524 (diff)
downloadflashrom-78ea7814ff3e4ae9ac9454fcbd4df6efd13708fd.zip
flashrom-78ea7814ff3e4ae9ac9454fcbd4df6efd13708fd.tar.gz
Fix garbage handling in DMI strings
Previously we tried to replace garbage characters with <space> directly in the read-only memory-mapped SMBIOS area(!). This could never have worked for any DMI strings with garbage and results in a segfault on machines with such strings. Thanks to Brian Rak (Supermicro X10SLE-F) and John Pohlman (HP XW9400) for reporting this issue. With this patch the strings are duplicated within dmi_string() already, just before we sanitize them. Also, the limit variable used everywhere points to the first invalid byte address. Refine respective checks accordingly. Corresponding to flashrom svn r1824. Signed-off-by: Stefan Tauner <stefan.tauner@alumni.tuwien.ac.at> Acked-by: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006@gmx.net>
Diffstat (limited to 'flashchips.c')
0 files changed, 0 insertions, 0 deletions
OpenPOWER on IntegriCloud