diff options
author | Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006@gmx.net> | 2009-04-22 13:33:43 +0000 |
---|---|---|
committer | Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006@gmx.net> | 2009-04-22 13:33:43 +0000 |
commit | 19e3aeb338cc2b94478ee5a4493822bd88223e78 (patch) | |
tree | a74a6b18258bf2dc80d0726ce420fe3cb061ac9a /flashchips.c | |
parent | 452bae5dc69de1f42106b299d7fc4a8a822b0f11 (diff) | |
download | flashrom-19e3aeb338cc2b94478ee5a4493822bd88223e78.zip flashrom-19e3aeb338cc2b94478ee5a4493822bd88223e78.tar.gz |
All "unknown xy SPI chip" entries claim to have status UNTESTED for probe/read/erase/write
That is incorrect. A bit of confusion comes from how the #defines are named.
We call them TEST_BAD_*, but the message printed by flashrom says: "This flash
part has status NOT WORKING for operations:" Something that is unimplemented
is definitely not working. Neither of the chip entries mentioned above has
erase or write functions implemented, so erase and write are not working.
Since their size is unknown, we can't read them in. That means read is not
working as well. Probing is a different matter. If a chip-specific probe
function had matched, we wouldn't have to handle the chip with the "unknown xy
SPI chip" fallback. I'm tempted to call that "not working" as well, but I'm
open to discussion on this point.
Corresponding to flashrom svn r439 and coreboot v2 svn r4177.
Signed-off-by: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006@gmx.net>
Acked-by: Uwe Hermann <uwe@hermann-uwe.de>
Diffstat (limited to 'flashchips.c')
-rw-r--r-- | flashchips.c | 12 |
1 files changed, 6 insertions, 6 deletions
diff --git a/flashchips.c b/flashchips.c index 911457f..bc16b2e 100644 --- a/flashchips.c +++ b/flashchips.c @@ -2167,7 +2167,7 @@ struct flashchip flashchips[] = { .model_id = GENERIC_DEVICE_ID, .total_size = 0, .page_size = 256, - .tested = TEST_UNTESTED, + .tested = TEST_BAD_PREW, .probe = probe_spi_rdid, .erase = NULL, .write = NULL, @@ -2180,7 +2180,7 @@ struct flashchip flashchips[] = { .model_id = GENERIC_DEVICE_ID, .total_size = 0, .page_size = 256, - .tested = TEST_UNTESTED, + .tested = TEST_BAD_PREW, .probe = probe_spi_rdid, .erase = NULL, .write = NULL, @@ -2193,7 +2193,7 @@ struct flashchip flashchips[] = { .model_id = GENERIC_DEVICE_ID, .total_size = 0, .page_size = 256, - .tested = TEST_UNTESTED, + .tested = TEST_BAD_PREW, .probe = probe_spi_rdid, .erase = NULL, .write = NULL, @@ -2206,7 +2206,7 @@ struct flashchip flashchips[] = { .model_id = GENERIC_DEVICE_ID, .total_size = 0, .page_size = 256, - .tested = TEST_UNTESTED, + .tested = TEST_BAD_PREW, .probe = probe_spi_rdid, .erase = NULL, .write = NULL, @@ -2219,7 +2219,7 @@ struct flashchip flashchips[] = { .model_id = GENERIC_DEVICE_ID, .total_size = 0, .page_size = 256, - .tested = TEST_UNTESTED, + .tested = TEST_BAD_PREW, .probe = probe_spi_rdid, .erase = NULL, .write = NULL, @@ -2232,7 +2232,7 @@ struct flashchip flashchips[] = { .model_id = GENERIC_DEVICE_ID, .total_size = 0, .page_size = 256, - .tested = TEST_UNTESTED, + .tested = TEST_BAD_PREW, .probe = probe_spi_rdid, .erase = NULL, .write = NULL, |