summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorCarl-Daniel Hailfinger <c-d.hailfinger.devel.2006@gmx.net>2010-05-22 07:27:16 +0000
committerCarl-Daniel Hailfinger <c-d.hailfinger.devel.2006@gmx.net>2010-05-22 07:27:16 +0000
commit5d249d86ce672a3725f0c08638c110f3149a2e00 (patch)
treee767011009853ed59a2868403fde57c58438a2a1
parent1e57c24060642fa663cb20e33d65f687bfbe28b0 (diff)
downloadflashrom-5d249d86ce672a3725f0c08638c110f3149a2e00.zip
flashrom-5d249d86ce672a3725f0c08638c110f3149a2e00.tar.gz
Fix Tyan S2915 OEM board by commenting out MCP55 LPC bridge PCI ID 10de:0361 which is the secondary LPC bridge
The same effect could be achieved by refusing to run enable_flash_mcp55 if the device class is not ISA bridge [0601]. Thanks to Alessandro Polverini, Joel Robertson, Nicolas Aveline, Phil LoCascio and Nils-Helge Garli Hegvik for testing flashrom on hardware and Michael Karcher for analyzing the factory BIOS for clues. In the end, no board enable was needed and it was a pure chipset issue. Corresponding to flashrom svn r1007. Signed-off-by: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006@gmx.net> Acked-by: Michael Karcher <flashrom@mkarcher.dialup.fu-berlin.de>
-rw-r--r--chipset_enable.c10
1 files changed, 9 insertions, 1 deletions
diff --git a/chipset_enable.c b/chipset_enable.c
index 69f1623..bad0596 100644
--- a/chipset_enable.c
+++ b/chipset_enable.c
@@ -1354,7 +1354,15 @@ const struct penable chipset_enables[] = {
{0x10de, 0x0262, NT, "NVIDIA", "MCP51", enable_flash_ck804},
{0x10de, 0x0263, NT, "NVIDIA", "MCP51", enable_flash_ck804},
{0x10de, 0x0360, OK, "NVIDIA", "MCP55", enable_flash_mcp55}, /* M57SLI*/
- {0x10de, 0x0361, OK, "NVIDIA", "MCP55", enable_flash_mcp55}, /* LPC */
+ /* 10de:0361 is present in Tyan S2915 OEM systems, but not connected to
+ * the flash chip. Instead, 10de:0364 is connected to the flash chip.
+ * Until we have PCI device class matching or some fallback mechanism,
+ * this is needed to get flashrom working on Tyan S2915 and maybe other
+ * dual-MCP55 boards.
+ */
+#if 0
+ {0x10de, 0x0361, NT, "NVIDIA", "MCP55", enable_flash_mcp55}, /* LPC */
+#endif
{0x10de, 0x0362, OK, "NVIDIA", "MCP55", enable_flash_mcp55}, /* LPC */
{0x10de, 0x0363, OK, "NVIDIA", "MCP55", enable_flash_mcp55}, /* LPC */
{0x10de, 0x0364, OK, "NVIDIA", "MCP55", enable_flash_mcp55}, /* LPC */
OpenPOWER on IntegriCloud