diff options
author | Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006@gmx.net> | 2009-12-22 23:54:10 +0000 |
---|---|---|
committer | Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006@gmx.net> | 2009-12-22 23:54:10 +0000 |
commit | 5a14614bf6dbf63a68c25a6e0075e357bd8484a5 (patch) | |
tree | ae622763f2f1d79b1c0366f60242d7e13f0a6340 | |
parent | 4e27addf88b2111d9789bfb00fbae1d12ffa286d (diff) | |
download | flashrom-5a14614bf6dbf63a68c25a6e0075e357bd8484a5.zip flashrom-5a14614bf6dbf63a68c25a6e0075e357bd8484a5.tar.gz |
Add a few FIXME comments to the generic SPI code
Corresponding to flashrom svn r814.
Signed-off-by: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006@gmx.net>
Acked-by: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006@gmx.net>
-rw-r--r-- | spi.c | 2 |
1 files changed, 2 insertions, 0 deletions
@@ -807,6 +807,7 @@ int spi_write_status_register(int status) int result; struct spi_command cmds[] = { { + /* FIXME: WRSR requires either EWSR or WREN depending on chip type. */ .writecnt = JEDEC_EWSR_OUTSIZE, .writearr = (const unsigned char[]){ JEDEC_EWSR }, .readcnt = 0, @@ -1059,6 +1060,7 @@ int spi_aai_write(struct flashchip *flash, uint8_t *buf) fprintf(stderr, "ERASE FAILED!\n"); return -1; } + /* FIXME: This will fail on ICH/VIA SPI. */ result = spi_write_enable(); if (result) return result; |