diff options
author | Stefan Tauner <stefan.tauner@alumni.tuwien.ac.at> | 2014-09-05 16:14:11 +0000 |
---|---|---|
committer | Stefan Tauner <stefan.tauner@alumni.tuwien.ac.at> | 2014-09-05 16:14:11 +0000 |
commit | 34087510a80cbb9b14177bb63558024e40b146ca (patch) | |
tree | 5535c4c92c161534ff1f14a7a3c2f104ab873b46 | |
parent | a905fb28d5c5d7af4d1e18190edad9171c0a34ed (diff) | |
download | flashrom-34087510a80cbb9b14177bb63558024e40b146ca.zip flashrom-34087510a80cbb9b14177bb63558024e40b146ca.tar.gz |
dmi.c: Duplicate returned strings because they are meant to be freed
Without this patch dmi_shutdown calls free() on read-only strings.
Corresponding to flashrom svn r1849.
Signed-off-by: Stefan Tauner <stefan.tauner@alumni.tuwien.ac.at>
Acked-by: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006@gmx.net>
-rw-r--r-- | dmi.c | 6 |
1 files changed, 3 insertions, 3 deletions
@@ -120,18 +120,18 @@ static char *dmi_string(const char *buf, uint8_t string_id, const char *limit) size_t i, len; if (string_id == 0) - return "Not Specified"; + return strdup("Not Specified"); while (string_id > 1 && string_id--) { if (buf >= limit) { msg_perr("DMI table is broken (string portion out of bounds)!\n"); - return "<OUT OF BOUNDS>"; + return strdup("<OUT OF BOUNDS>"); } buf += strnlen(buf, limit - buf) + 1; } if (!*buf) /* as long as the current byte we're on isn't null */ - return "<BAD INDEX>"; + return strdup("<BAD INDEX>"); len = strnlen(buf, limit - buf); char *newbuf = malloc(len + 1); |