summaryrefslogtreecommitdiffstats
path: root/libswscale
diff options
context:
space:
mode:
authorJames Cowgill <James.Cowgill@imgtec.com>2017-08-03 16:21:54 +0100
committerMichael Niedermayer <michael@niedermayer.cc>2017-08-05 23:24:02 +0200
commit013ec23cbe5d78a04b1b6c00c43f45773e45e7e5 (patch)
treed624f5dab704e49d678193763b29f2b8a8a3d621 /libswscale
parent2cc56741b1f4e33c4fdb8234da31bdfc3c5c5e05 (diff)
downloadffmpeg-streaming-013ec23cbe5d78a04b1b6c00c43f45773e45e7e5.zip
ffmpeg-streaming-013ec23cbe5d78a04b1b6c00c43f45773e45e7e5.tar.gz
swscale: fix gbrap16 alpha channel issues
Fixes filter-pixfmts-scale test failing on big-endian systems due to alpSrc not being cast to (const int32_t**). Also fixes distortions in the output alpha channel values by copying the alpha channel code from the rgba64 case found elsewhere in output.c. Fixes ticket 6555. Signed-off-by: James Cowgill <James.Cowgill@imgtec.com> Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
Diffstat (limited to 'libswscale')
-rw-r--r--libswscale/output.c16
1 files changed, 8 insertions, 8 deletions
diff --git a/libswscale/output.c b/libswscale/output.c
index 9774e9f..f30bce8 100644
--- a/libswscale/output.c
+++ b/libswscale/output.c
@@ -2026,24 +2026,24 @@ yuv2gbrp16_full_X_c(SwsContext *c, const int16_t *lumFilter,
const int16_t **lumSrcx, int lumFilterSize,
const int16_t *chrFilter, const int16_t **chrUSrcx,
const int16_t **chrVSrcx, int chrFilterSize,
- const int16_t **alpSrc, uint8_t **dest,
+ const int16_t **alpSrcx, uint8_t **dest,
int dstW, int y)
{
const AVPixFmtDescriptor *desc = av_pix_fmt_desc_get(c->dstFormat);
int i;
- int hasAlpha = (desc->flags & AV_PIX_FMT_FLAG_ALPHA) && alpSrc;
+ int hasAlpha = (desc->flags & AV_PIX_FMT_FLAG_ALPHA) && alpSrcx;
uint16_t **dest16 = (uint16_t**)dest;
const int32_t **lumSrc = (const int32_t**)lumSrcx;
const int32_t **chrUSrc = (const int32_t**)chrUSrcx;
const int32_t **chrVSrc = (const int32_t**)chrVSrcx;
- int A = 0; // init to silence warning
+ const int32_t **alpSrc = (const int32_t**)alpSrcx;
for (i = 0; i < dstW; i++) {
int j;
int Y = -0x40000000;
int U = -(128 << 23);
int V = -(128 << 23);
- int R, G, B;
+ int R, G, B, A;
for (j = 0; j < lumFilterSize; j++)
Y += lumSrc[j][i] * (unsigned)lumFilter[j];
@@ -2059,13 +2059,13 @@ yuv2gbrp16_full_X_c(SwsContext *c, const int16_t *lumFilter,
V >>= 14;
if (hasAlpha) {
- A = 1 << 18;
+ A = -0x40000000;
for (j = 0; j < lumFilterSize; j++)
A += alpSrc[j][i] * lumFilter[j];
- if (A & 0xF8000000)
- A = av_clip_uintp2(A, 27);
+ A >>= 1;
+ A += 0x20002000;
}
Y -= c->yuv2rgb_y_offset;
@@ -2083,7 +2083,7 @@ yuv2gbrp16_full_X_c(SwsContext *c, const int16_t *lumFilter,
dest16[1][i] = B >> 14;
dest16[2][i] = R >> 14;
if (hasAlpha)
- dest16[3][i] = A >> 11;
+ dest16[3][i] = av_clip_uintp2(A, 30) >> 14;
}
if ((!isBE(c->dstFormat)) != (!HAVE_BIGENDIAN)) {
for (i = 0; i < dstW; i++) {
OpenPOWER on IntegriCloud