summaryrefslogtreecommitdiffstats
path: root/libavformat
diff options
context:
space:
mode:
authorMatt Wolenetz <wolenetz@google.com>2016-12-14 15:24:42 -0800
committerMichael Niedermayer <michael@niedermayer.cc>2017-02-08 03:31:01 +0100
commitfd30e4d57fe5841385f845440688505b88c0f4a9 (patch)
treeed1feed6d70bb38162adf92626fddeb5f41a264d /libavformat
parent1835ed19bb16f2963ef566560a2b4faf3d754fd2 (diff)
downloadffmpeg-streaming-fd30e4d57fe5841385f845440688505b88c0f4a9.zip
ffmpeg-streaming-fd30e4d57fe5841385f845440688505b88c0f4a9.tar.gz
lavf/mov.c: Avoid heap allocation wrap in mov_read_hdlr
Core of patch is from paul@paulmehta.com Reference https://crbug.com/643950 Signed-off-by: Michael Niedermayer <michael@niedermayer.cc> Check value reduced as the code does not support larger lengths
Diffstat (limited to 'libavformat')
-rw-r--r--libavformat/mov.c2
1 files changed, 2 insertions, 0 deletions
diff --git a/libavformat/mov.c b/libavformat/mov.c
index 6fd43a0..8c54539 100644
--- a/libavformat/mov.c
+++ b/libavformat/mov.c
@@ -742,6 +742,8 @@ static int mov_read_hdlr(MOVContext *c, AVIOContext *pb, MOVAtom atom)
title_size = atom.size - 24;
if (title_size > 0) {
+ if (title_size > FFMIN(INT_MAX, SIZE_MAX-1))
+ return AVERROR_INVALIDDATA;
title_str = av_malloc(title_size + 1); /* Add null terminator */
if (!title_str)
return AVERROR(ENOMEM);
OpenPOWER on IntegriCloud