summaryrefslogtreecommitdiffstats
path: root/libavformat
diff options
context:
space:
mode:
authorAndreas Rheinhardt <andreas.rheinhardt@gmail.com>2019-10-25 03:38:07 +0200
committerMichael Niedermayer <michael@niedermayer.cc>2019-10-25 23:27:02 +0200
commit2e37237ff107ea7175e15fed5e2f8d8aba80e225 (patch)
treed9c59e911029ffe4f060e63a7df773171056dbae /libavformat
parent296296a4d5194977bbcbc3656aec5823ffa46327 (diff)
downloadffmpeg-streaming-2e37237ff107ea7175e15fed5e2f8d8aba80e225.zip
ffmpeg-streaming-2e37237ff107ea7175e15fed5e2f8d8aba80e225.tar.gz
avformat/aiffenc: Add deinit function
Prevents memleaks if the trailer is never written. Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt@gmail.com> Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
Diffstat (limited to 'libavformat')
-rw-r--r--libavformat/aiffenc.c13
1 files changed, 9 insertions, 4 deletions
diff --git a/libavformat/aiffenc.c b/libavformat/aiffenc.c
index d37b9ae..e25794d 100644
--- a/libavformat/aiffenc.c
+++ b/libavformat/aiffenc.c
@@ -260,7 +260,7 @@ static int aiff_write_trailer(AVFormatContext *s)
/* Write ID3 tags */
if (aiff->write_id3v2)
if ((ret = put_id3v2_tags(s, aiff)) < 0)
- goto free;
+ return ret;
/* File length */
file_size = avio_tell(pb);
@@ -270,12 +270,16 @@ static int aiff_write_trailer(AVFormatContext *s)
avio_flush(pb);
}
-free:
- ff_packet_list_free(&aiff->pict_list, &aiff->pict_list_end);
-
return ret;
}
+static void aiff_deinit(AVFormatContext *s)
+{
+ AIFFOutputContext *aiff = s->priv_data;
+
+ ff_packet_list_free(&aiff->pict_list, &aiff->pict_list_end);
+}
+
#define OFFSET(x) offsetof(AIFFOutputContext, x)
#define ENC AV_OPT_FLAG_ENCODING_PARAM
static const AVOption options[] = {
@@ -304,6 +308,7 @@ AVOutputFormat ff_aiff_muxer = {
.write_header = aiff_write_header,
.write_packet = aiff_write_packet,
.write_trailer = aiff_write_trailer,
+ .deinit = aiff_deinit,
.codec_tag = (const AVCodecTag* const []){ ff_codec_aiff_tags, 0 },
.priv_class = &aiff_muxer_class,
};
OpenPOWER on IntegriCloud