diff options
| author | Alex Converse <alex.converse@gmail.com> | 2010-08-03 00:25:06 +0000 |
|---|---|---|
| committer | Alex Converse <alex.converse@gmail.com> | 2010-08-03 00:25:06 +0000 |
| commit | 366d919016a679d3955f6fe5278fa7ce4f47b81e (patch) | |
| tree | 4a8dcaeea99ef09bae878c6ce164f0eb6a2f9b88 /libavcodec/vorbis_dec.c | |
| parent | 83abdf5ff059649635e7e7e16c528e1973ac8a67 (diff) | |
| download | ffmpeg-streaming-366d919016a679d3955f6fe5278fa7ce4f47b81e.zip ffmpeg-streaming-366d919016a679d3955f6fe5278fa7ce4f47b81e.tar.gz | |
vorbisdec: Prevent a potential integer overflow.
If sizeof uint_fast8_t > 1 and sizeof size_t <= 4, the expression that mallocs
classifs is susceptible to integer overflow.
Originally committed as revision 24675 to svn://svn.ffmpeg.org/ffmpeg/trunk
Diffstat (limited to 'libavcodec/vorbis_dec.c')
| -rw-r--r-- | libavcodec/vorbis_dec.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/libavcodec/vorbis_dec.c b/libavcodec/vorbis_dec.c index 1772e55..b543f5c 100644 --- a/libavcodec/vorbis_dec.c +++ b/libavcodec/vorbis_dec.c @@ -103,7 +103,7 @@ typedef struct { int_fast16_t books[64][8]; uint_fast8_t maxpass; uint_fast16_t ptns_to_read; - uint_fast8_t *classifs; + uint8_t *classifs; } vorbis_residue; typedef struct { @@ -1267,7 +1267,7 @@ static av_always_inline int vorbis_residue_decode_internal(vorbis_context *vc, GetBitContext *gb = &vc->gb; uint_fast8_t c_p_c = vc->codebooks[vr->classbook].dimensions; uint_fast16_t ptns_to_read = vr->ptns_to_read; - uint_fast8_t *classifs = vr->classifs; + uint8_t *classifs = vr->classifs; uint_fast8_t pass; uint_fast8_t ch_used; uint_fast8_t i,j,l; |
