summaryrefslogtreecommitdiffstats
path: root/libavcodec/mpeg4videodec.c
diff options
context:
space:
mode:
authorMichael Niedermayer <michael@niedermayer.cc>2017-03-08 22:25:08 +0100
committerMichael Niedermayer <michael@niedermayer.cc>2017-03-09 23:28:10 +0100
commite2a4f1a9eb2c1ef3feed4a4f04db7629f2b61084 (patch)
tree42839175a3383ee896d9aab05b04ef2faa57bad2 /libavcodec/mpeg4videodec.c
parent222c9f031de3315af62be6d7a99c71105e516088 (diff)
downloadffmpeg-streaming-e2a4f1a9eb2c1ef3feed4a4f04db7629f2b61084.zip
ffmpeg-streaming-e2a4f1a9eb2c1ef3feed4a4f04db7629f2b61084.tar.gz
avcodec/mpeg4videodec: Fix runtime error: signed integer overflow: -135088512 * 16 cannot be represented in type 'int'
Fixes: 736/clusterfuzz-testcase-5580263943831552 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/targets/ffmpeg Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
Diffstat (limited to 'libavcodec/mpeg4videodec.c')
-rw-r--r--libavcodec/mpeg4videodec.c12
1 files changed, 11 insertions, 1 deletions
diff --git a/libavcodec/mpeg4videodec.c b/libavcodec/mpeg4videodec.c
index 128469d..791a07b 100644
--- a/libavcodec/mpeg4videodec.c
+++ b/libavcodec/mpeg4videodec.c
@@ -387,11 +387,21 @@ static int mpeg4_decode_sprite_trajectory(Mpeg4DecContext *ctx, GetBitContext *g
}
for (i = 0; i < 2; i++) {
+ int64_t sd[2] = {
+ s->sprite_delta[i][0] - a * (1LL<<16),
+ s->sprite_delta[i][1] - a * (1LL<<16)
+ };
+
if (llabs(s->sprite_offset[0][i] + s->sprite_delta[i][0] * (w+16LL)) >= INT_MAX ||
llabs(s->sprite_offset[0][i] + s->sprite_delta[i][1] * (h+16LL)) >= INT_MAX ||
llabs(s->sprite_offset[0][i] + s->sprite_delta[i][0] * (w+16LL) + s->sprite_delta[i][1] * (h+16LL)) >= INT_MAX ||
llabs(s->sprite_delta[i][0] * (w+16LL)) >= INT_MAX ||
- llabs(s->sprite_delta[i][1] * (w+16LL)) >= INT_MAX
+ llabs(s->sprite_delta[i][1] * (w+16LL)) >= INT_MAX ||
+ llabs(sd[0]) >= INT_MAX ||
+ llabs(sd[1]) >= INT_MAX ||
+ llabs(s->sprite_offset[0][i] + sd[0] * (w+16LL)) >= INT_MAX ||
+ llabs(s->sprite_offset[0][i] + sd[1] * (h+16LL)) >= INT_MAX ||
+ llabs(s->sprite_offset[0][i] + sd[0] * (w+16LL) + sd[1] * (h+16LL)) >= INT_MAX
) {
avpriv_request_sample(s->avctx, "Overflow on sprite points");
goto overflow;
OpenPOWER on IntegriCloud