diff options
Diffstat (limited to 'src/southbridge')
21 files changed, 90 insertions, 90 deletions
diff --git a/src/southbridge/intel/i82801gx/acpi/globalnvs.asl b/src/southbridge/intel/i82801gx/acpi/globalnvs.asl index 368e906..5ac1c83 100644 --- a/src/southbridge/intel/i82801gx/acpi/globalnvs.asl +++ b/src/southbridge/intel/i82801gx/acpi/globalnvs.asl @@ -24,7 +24,7 @@ Name(\PICM, 0) // IOAPIC/8259 Name(\DSEN, 1) // Display Output Switching Enable -/* Global ACPI memory region. This region is used for passing information +/* Global ACPI memory region. This region is used for passing information * between coreboot (aka "the system bios"), ACPI, and the SMI handler. * Since we don't know where this will end up in memory at ACPI compile time, * we have to fix it up in coreboot's ACPI creation phase. diff --git a/src/southbridge/intel/i82801gx/acpi/ich7.asl b/src/southbridge/intel/i82801gx/acpi/ich7.asl index dd3bc87..3f845c4 100644 --- a/src/southbridge/intel/i82801gx/acpi/ich7.asl +++ b/src/southbridge/intel/i82801gx/acpi/ich7.asl @@ -108,7 +108,7 @@ Scope(\) Offset(0x1000), // Chipset Offset(0x3000), // Legacy Configuration Registers Offset(0x3404), // High Performance Timer Configuration - HPAS, 2, // Address Select + HPAS, 2, // Address Select , 5, HPTE, 1, // Address Enable Offset(0x3418), // FD (Function Disable) @@ -135,7 +135,7 @@ Scope(\) RP5D, 1, // Root Port 5 disable RP6D, 1 // Root Port 6 disable } - + } // 0:1b.0 High Definition Audio (Azalia) diff --git a/src/southbridge/intel/i82801gx/acpi/ich7_ac97.asl b/src/southbridge/intel/i82801gx/acpi/ich7_ac97.asl index 7f76ccc..8a8cf82 100644 --- a/src/southbridge/intel/i82801gx/acpi/ich7_ac97.asl +++ b/src/southbridge/intel/i82801gx/acpi/ich7_ac97.asl @@ -33,7 +33,7 @@ Device (AUD0) Device (MODM) { Name (_ADR, 0x001e0003) - + Name (_PRW, Package(){ 5, 4 }) } diff --git a/src/southbridge/intel/i82801gx/acpi/ich7_audio.asl b/src/southbridge/intel/i82801gx/acpi/ich7_audio.asl index 5b8b386..d03be4f 100644 --- a/src/southbridge/intel/i82801gx/acpi/ich7_audio.asl +++ b/src/southbridge/intel/i82801gx/acpi/ich7_audio.asl @@ -28,7 +28,7 @@ Device (HDEF) Name (_ADR, 0x001b0000) // Power Resources for Wake - Name (_PRW, Package(){ + Name (_PRW, Package(){ 5, // Bit 5 of GPE 4 // Can wake from S4 state. }) diff --git a/src/southbridge/intel/i82801gx/acpi/ich7_irqlinks.asl b/src/southbridge/intel/i82801gx/acpi/ich7_irqlinks.asl index e993dd3..5fcee45 100644 --- a/src/southbridge/intel/i82801gx/acpi/ich7_irqlinks.asl +++ b/src/southbridge/intel/i82801gx/acpi/ich7_irqlinks.asl @@ -36,7 +36,7 @@ Device (LNKA) IRQ(Level, ActiveLow, Shared) { 1, 3, 4, 5, 6, 7, 10, 12, 14, 15 } }) - + // Current Resource Settings for this link Method (_CRS, 0, Serialized) { @@ -95,7 +95,7 @@ Device (LNKB) IRQ(Level, ActiveLow, Shared) { 1, 3, 4, 5, 6, 7, 11, 12, 14, 15 } }) - + // Current Resource Settings for this link Method (_CRS, 0, Serialized) { @@ -154,7 +154,7 @@ Device (LNKC) IRQ(Level, ActiveLow, Shared) { 1, 3, 4, 5, 6, 7, 10, 12, 14, 15 } }) - + // Current Resource Settings for this link Method (_CRS, 0, Serialized) { @@ -213,7 +213,7 @@ Device (LNKD) IRQ(Level, ActiveLow, Shared) { 1, 3, 4, 5, 6, 7, 11, 12, 14, 15 } }) - + // Current Resource Settings for this link Method (_CRS, 0, Serialized) { @@ -272,7 +272,7 @@ Device (LNKE) IRQ(Level, ActiveLow, Shared) { 1, 3, 4, 5, 6, 7, 10, 12, 14, 15 } }) - + // Current Resource Settings for this link Method (_CRS, 0, Serialized) { @@ -331,7 +331,7 @@ Device (LNKF) IRQ(Level, ActiveLow, Shared) { 1, 3, 4, 5, 6, 7, 11, 12, 14, 15 } }) - + // Current Resource Settings for this link Method (_CRS, 0, Serialized) { @@ -390,7 +390,7 @@ Device (LNKG) IRQ(Level, ActiveLow, Shared) { 1, 3, 4, 5, 6, 7, 10, 12, 14, 15 } }) - + // Current Resource Settings for this link Method (_CRS, 0, Serialized) { @@ -449,7 +449,7 @@ Device (LNKH) IRQ(Level, ActiveLow, Shared) { 1, 3, 4, 5, 6, 7, 11, 12, 14, 15 } }) - + // Current Resource Settings for this link Method (_CRS, 0, Serialized) { diff --git a/src/southbridge/intel/i82801gx/acpi/ich7_lpc.asl b/src/southbridge/intel/i82801gx/acpi/ich7_lpc.asl index d570539..fdf05b2 100644 --- a/src/southbridge/intel/i82801gx/acpi/ich7_lpc.asl +++ b/src/southbridge/intel/i82801gx/acpi/ich7_lpc.asl @@ -24,7 +24,7 @@ Device (LPCB) { Name(_ADR, 0x001f0000) - + OperationRegion(LPC0, PCI_Config, 0x00, 0x100) Field (LPC0, AnyAcc, NoLock, Preserve) { @@ -52,7 +52,7 @@ Device (LPCB) } Include ("../../../southbridge/intel/i82801gx/acpi/ich7_irqlinks.asl") - + Include ("acpi/ec.asl") Device (DMAC) // DMA Controller diff --git a/src/southbridge/intel/i82801gx/acpi/ich7_pata.asl b/src/southbridge/intel/i82801gx/acpi/ich7_pata.asl index f12522a..1905ed2 100644 --- a/src/southbridge/intel/i82801gx/acpi/ich7_pata.asl +++ b/src/southbridge/intel/i82801gx/acpi/ich7_pata.asl @@ -41,7 +41,7 @@ Device (PATA) CreateDwordField (PBUF, 4, DMA0) CreateDwordField (PBUF, 8, PIO1) CreateDwordField (PBUF, 12, DMA1) - CreateDwordField (PBUF, 16, FLAG) + CreateDwordField (PBUF, 16, FLAG) // TODO fill return structure @@ -55,7 +55,7 @@ Device (PATA) CreateDwordField (Arg0, 4, DMA0) CreateDwordField (Arg0, 8, PIO1) CreateDwordField (Arg0, 12, DMA1) - CreateDwordField (Arg0, 16, FLAG) + CreateDwordField (Arg0, 16, FLAG) // TODO: Do the deed } diff --git a/src/southbridge/intel/i82801gx/acpi/ich7_pci.asl b/src/southbridge/intel/i82801gx/acpi/ich7_pci.asl index 775a34d..9bcf58e 100644 --- a/src/southbridge/intel/i82801gx/acpi/ich7_pci.asl +++ b/src/southbridge/intel/i82801gx/acpi/ich7_pci.asl @@ -64,7 +64,7 @@ Device (PCIB) // TODO: How many slots, where? // PCI Interrupt Routing. - // If PICM is set, interrupts are routed over the i8259, otherwise + // If PICM is set, interrupts are routed over the i8259, otherwise // over the IOAPIC. (Really? If they're above 15 they need to be routed // fixed over the IOAPIC?) diff --git a/src/southbridge/intel/i82801gx/acpi/ich7_sata.asl b/src/southbridge/intel/i82801gx/acpi/ich7_sata.asl index bf7a06a..e0c336a 100644 --- a/src/southbridge/intel/i82801gx/acpi/ich7_sata.asl +++ b/src/southbridge/intel/i82801gx/acpi/ich7_sata.asl @@ -44,7 +44,7 @@ Device (SATA) CreateDwordField (PBUF, 4, DMA0) CreateDwordField (PBUF, 8, PIO1) CreateDwordField (PBUF, 12, DMA1) - CreateDwordField (PBUF, 16, FLAG) + CreateDwordField (PBUF, 16, FLAG) // TODO fill return structure @@ -58,7 +58,7 @@ Device (SATA) CreateDwordField (Arg0, 4, DMA0) CreateDwordField (Arg0, 8, PIO1) CreateDwordField (Arg0, 12, DMA1) - CreateDwordField (Arg0, 16, FLAG) + CreateDwordField (Arg0, 16, FLAG) // TODO: Do the deed } diff --git a/src/southbridge/intel/i82801gx/acpi/ich7_smbus.asl b/src/southbridge/intel/i82801gx/acpi/ich7_smbus.asl index 6b1009c..b7d807e 100644 --- a/src/southbridge/intel/i82801gx/acpi/ich7_smbus.asl +++ b/src/southbridge/intel/i82801gx/acpi/ich7_smbus.asl @@ -24,7 +24,7 @@ Device (SBUS) { Name (_ADR, 0x001f0003) - + OperationRegion (SMBP, PCI_Config, 0x00, 0x100) Field(SMBP, DWordAcc, NoLock, Preserve) { @@ -102,7 +102,7 @@ Device (SBUS) Store (0, Local0) // We're ready } } - + Store (4000, Local0) // Timeout 200ms (50us * 4000) While (Local0) { If (And (HSTS, 0x01)) { // Host Busy? diff --git a/src/southbridge/intel/i82801gx/acpi/ich7_usb.asl b/src/southbridge/intel/i82801gx/acpi/ich7_usb.asl index 99a2cb9..9ae9909 100644 --- a/src/southbridge/intel/i82801gx/acpi/ich7_usb.asl +++ b/src/southbridge/intel/i82801gx/acpi/ich7_usb.asl @@ -26,7 +26,7 @@ Device (USB1) { Name(_ADR, 0x001d0000) - + OperationRegion(U01P, PCI_Config, 0, 256) Field(U01P, DWordAcc, NoLock, Preserve) { @@ -35,7 +35,7 @@ Device (USB1) } Name (_PRW, Package(){ 3, 4 }) // Power Resources for Wake - + Method (_PSW, 1) // Power State Wake method { // USB Controller can wake OS from Sleep State @@ -65,7 +65,7 @@ Device (USB1) Device (USB2) { Name(_ADR, 0x001d0001) - + OperationRegion(U02P, PCI_Config, 0, 256) Field(U02P, DWordAcc, NoLock, Preserve) { @@ -74,7 +74,7 @@ Device (USB2) } Name (_PRW, Package(){ 3, 4 }) // Power Resources for Wake - + Method (_PSW, 1) // Power State Wake method { // USB Controller can wake OS from Sleep State @@ -105,7 +105,7 @@ Device (USB2) Device (USB3) { Name(_ADR, 0x001d0002) - + OperationRegion(U03P, PCI_Config, 0, 256) Field(U03P, DWordAcc, NoLock, Preserve) { @@ -114,7 +114,7 @@ Device (USB3) } Name (_PRW, Package(){ 3, 4 }) // Power Resources for Wake - + Method (_PSW, 1) // Power State Wake method { // USB Controller can wake OS from Sleep State @@ -145,7 +145,7 @@ Device (USB3) Device (USB4) { Name(_ADR, 0x001d0003) - + OperationRegion(U04P, PCI_Config, 0, 256) Field(U04P, DWordAcc, NoLock, Preserve) { @@ -154,7 +154,7 @@ Device (USB4) } Name (_PRW, Package(){ 3, 4 }) // Power Resources for Wake - + Method (_PSW, 1) // Power State Wake method { // USB Controller can wake OS from Sleep State @@ -185,9 +185,9 @@ Device (USB4) Device (EHC1) { Name(_ADR, 0x001d0007) - + Name (_PRW, Package(){ 13, 4 }) // Power Resources for Wake - + // Leave USB ports on for to allow Wake from USB Method(_S3D,0) // Highest D State in S3 State diff --git a/src/southbridge/intel/i82801gx/i82801gx.h b/src/southbridge/intel/i82801gx/i82801gx.h index 19472ed..98c62ce 100644 --- a/src/southbridge/intel/i82801gx/i82801gx.h +++ b/src/southbridge/intel/i82801gx/i82801gx.h @@ -109,11 +109,11 @@ extern void i82801gx_enable(device_t dev); #define HST_EN (1 << 0) /* SMBus I/O bits. - * It does not matter where we put the SMBus I/O base, as long as we + * It does not matter where we put the SMBus I/O base, as long as we * keep it consistent and don't interfere with other devices. Stage2 * will relocate this anyways. * Our solution is to have SMB initialization move the I/O to SMBUS_IO_BASE - * again. But handling static BARs is a generic problem that should be + * again. But handling static BARs is a generic problem that should be * solved in the device allocator. */ #define SMBUS_IO_BASE 0x0400 diff --git a/src/southbridge/intel/i82801gx/i82801gx_ac97.c b/src/southbridge/intel/i82801gx/i82801gx_ac97.c index f447de6..f1e4107 100644 --- a/src/southbridge/intel/i82801gx/i82801gx_ac97.c +++ b/src/southbridge/intel/i82801gx/i82801gx_ac97.c @@ -145,7 +145,7 @@ static void ac97_audio_init(struct device *dev) printk_debug("No primary codec. Disabling AC'97 Audio.\n"); return; } - + ac97_semaphore(); /* Detect if codec is programmable */ diff --git a/src/southbridge/intel/i82801gx/i82801gx_azalia.c b/src/southbridge/intel/i82801gx/i82801gx_azalia.c index d0f3514..1435866 100644 --- a/src/southbridge/intel/i82801gx/i82801gx_azalia.c +++ b/src/southbridge/intel/i82801gx/i82801gx_azalia.c @@ -45,8 +45,8 @@ static int set_bits(u8 * port, u32 mask, u32 val) reg32 |= val; writel(reg32, port); - /* Wait for readback of register to - * match what was just written to it + /* Wait for readback of register to + * match what was just written to it */ count = 50; do { @@ -67,11 +67,11 @@ static int codec_detect(u8 * base) u32 reg32; /* Set Bit0 to 0 to enter reset state (BAR + 0x8)[0] */ - if (set_bits(base + 0x08, 1, 0) == -1) + if (set_bits(base + 0x08, 1, 0) == -1) goto no_codec; /* Set Bit 0 to 1 to exit reset state (BAR + 0x8)[0] */ - if (set_bits(base + 0x08, 1, 1) == -1) + if (set_bits(base + 0x08, 1, 1) == -1) goto no_codec; /* Read in Codec location (BAR + 0xe)[2..0]*/ @@ -79,7 +79,7 @@ static int codec_detect(u8 * base) reg32 &= 0x0f; if (!reg32) goto no_codec; - + return reg32; no_codec: @@ -161,7 +161,7 @@ static u32 cim_verb_data[] = { static unsigned find_verb(struct device *dev, u32 viddid, u32 ** verb) { config_t *config = dev->chip_info; - + if (config == NULL) { printk_err("\ni82801gx_azalia: Not mentioned in mainboard's Config.lb!\n"); return 0; @@ -309,7 +309,7 @@ static void azalia_init(struct device *dev) // VCi Resource Control reg32 = pci_mmio_read_config32(dev, 0x120); - reg32 |= (1 << 31); + reg32 |= (1 << 31); reg32 |= (1 << 24); // VCi ID reg32 |= (0x80 << 0); // VCi map pci_mmio_write_config32(dev, 0x120, reg32); diff --git a/src/southbridge/intel/i82801gx/i82801gx_lpc.c b/src/southbridge/intel/i82801gx/i82801gx_lpc.c index 97a6ed2..bed5dce 100644 --- a/src/southbridge/intel/i82801gx/i82801gx_lpc.c +++ b/src/southbridge/intel/i82801gx/i82801gx_lpc.c @@ -73,7 +73,7 @@ static void i82801gx_enable_apic(struct device *dev) volatile u32 *ioapic_index = (volatile u32 *)0xfec00000; volatile u32 *ioapic_data = (volatile u32 *)0xfec00010; - /* Enable ACPI I/O and power management. + /* Enable ACPI I/O and power management. * Set SCI IRQ to IRQ9 */ pci_write_config8(dev, ACPI_CNTL, 0x80); @@ -275,7 +275,7 @@ static void i82801gx_power_options(device_t dev) reg32 = inl(pmbase + 0x04); // PM1_CNT #if CONFIG_HAVE_ACPI_RESUME acpi_slp_type = (((reg32 >> 10) & 7) == 5) ? 3 : 0; - printk_debug("PM1_CNT: 0x%08x --> acpi_sleep_type: %x\n", + printk_debug("PM1_CNT: 0x%08x --> acpi_sleep_type: %x\n", reg32, acpi_slp_type); #endif reg32 |= (1 << 1); // enable C3->C0 transition on bus master @@ -286,7 +286,7 @@ static void i82801gx_power_options(device_t dev) static void i82801gx_configure_cstates(device_t dev) { u8 reg8; - + reg8 = pci_read_config8(dev, 0xa9); // Cx state configuration reg8 |= (1 << 4) | (1 << 3) | (1 << 2); // Enable Popup & Popdown pci_write_config8(dev, 0xa9, reg8); @@ -318,7 +318,7 @@ static void i82801gx_rtc_init(struct device *dev) static void enable_hpet(void) { u32 reg32; - + /* Move HPET to default address 0xfed00000 and enable it */ reg32 = RCBA32(0x3404); reg32 |= (1 << 7); // HPET Address Enable @@ -329,7 +329,7 @@ static void enable_hpet(void) static void enable_clock_gating(void) { u32 reg32; - + /* Enable Clock Gating for most devices */ reg32 = RCBA32(0x341c); reg32 |= (1 << 31); // LPC clock gating @@ -360,7 +360,7 @@ static void i82801gx_lock_smm(struct device *dev) outb(0x1e, 0xb2); // Disable ACPI mode printk_debug("done.\n"); #endif - /* Don't allow evil boot loaders, kernels, or + /* Don't allow evil boot loaders, kernels, or * userspace applications to deceive us: */ smm_lock(); diff --git a/src/southbridge/intel/i82801gx/i82801gx_pci.c b/src/southbridge/intel/i82801gx/i82801gx_pci.c index 2e1a251..215563d 100644 --- a/src/southbridge/intel/i82801gx/i82801gx_pci.c +++ b/src/southbridge/intel/i82801gx/i82801gx_pci.c @@ -71,10 +71,10 @@ static void ich_pci_dev_enable_resources(struct device *dev) ops = ops_pci(dev); if (dev->on_mainboard && ops && ops->set_subsystem) { printk_debug("%s subsystem <- %02x/%02x\n", - dev_path(dev), + dev_path(dev), CONFIG_MAINBOARD_PCI_SUBSYSTEM_VENDOR_ID, CONFIG_MAINBOARD_PCI_SUBSYSTEM_DEVICE_ID); - ops->set_subsystem(dev, + ops->set_subsystem(dev, CONFIG_MAINBOARD_PCI_SUBSYSTEM_VENDOR_ID, CONFIG_MAINBOARD_PCI_SUBSYSTEM_DEVICE_ID); } @@ -82,7 +82,7 @@ static void ich_pci_dev_enable_resources(struct device *dev) command = pci_read_config16(dev, PCI_COMMAND); command |= dev->command; #ifdef PCI_BRIDGE_UPDATE_COMMAND - /* If we write to PCI_COMMAND, on some systems + /* If we write to PCI_COMMAND, on some systems * this will cause the ROM and APICs not being visible * anymore. */ diff --git a/src/southbridge/intel/i82801gx/i82801gx_pcie.c b/src/southbridge/intel/i82801gx/i82801gx_pcie.c index d7655c5..67120d6 100644 --- a/src/southbridge/intel/i82801gx/i82801gx_pcie.c +++ b/src/southbridge/intel/i82801gx/i82801gx_pcie.c @@ -29,7 +29,7 @@ static void pci_init(struct device *dev) u32 reg32; printk_debug("Initializing ICH7 PCIe bridge.\n"); - + /* Enable Bus Master */ reg32 = pci_read_config32(dev, PCI_COMMAND); reg32 |= PCI_COMMAND_MASTER; diff --git a/src/southbridge/intel/i82801gx/i82801gx_sata.c b/src/southbridge/intel/i82801gx/i82801gx_sata.c index 74ba823..ddfe08d 100644 --- a/src/southbridge/intel/i82801gx/i82801gx_sata.c +++ b/src/southbridge/intel/i82801gx/i82801gx_sata.c @@ -132,26 +132,26 @@ static void sata_init(struct device *dev) /* Set Interrupt Line */ /* Interrupt Pin is set by D31IP.PIP */ pci_write_config8(dev, INTR_LN, 0xff); - + /* Set timings */ pci_write_config16(dev, IDE_TIM_PRI, IDE_DECODE_ENABLE | IDE_ISP_3_CLOCKS | IDE_RCT_1_CLOCKS | IDE_PPE0 | IDE_IE0 | IDE_TIME0); pci_write_config16(dev, IDE_TIM_SEC, IDE_DECODE_ENABLE | - IDE_SITRE | IDE_ISP_3_CLOCKS | + IDE_SITRE | IDE_ISP_3_CLOCKS | IDE_RCT_1_CLOCKS | IDE_IE0 | IDE_TIME0); - + /* Sync DMA */ pci_write_config16(dev, IDE_SDMA_CNT, IDE_SSDE0 | IDE_PSDE0); pci_write_config16(dev, IDE_SDMA_TIM, 0x0201); - + /* Set IDE I/O Configuration */ reg32 = SIG_MODE_NORMAL | FAST_PCB1 | FAST_PCB0 | PCB1 | PCB0; pci_write_config32(dev, IDE_CONFIG, reg32); - + /* Port 0 & 1 enable XXX */ pci_write_config8(dev, 0x92, 0x15); - + /* SATA Initialization register */ pci_write_config32(dev, 0x94, 0x1a000180); } diff --git a/src/southbridge/intel/i82801gx/i82801gx_smbus.c b/src/southbridge/intel/i82801gx/i82801gx_smbus.c index ee9f47e..4306055 100644 --- a/src/southbridge/intel/i82801gx/i82801gx_smbus.c +++ b/src/southbridge/intel/i82801gx/i82801gx_smbus.c @@ -28,7 +28,7 @@ #include <arch/io.h> #include "i82801gx.h" #include "i82801gx_smbus.h" - + #define SMB_BASE 0x20 static void smbus_init(struct device *dev) { diff --git a/src/southbridge/intel/i82801gx/i82801gx_smi.c b/src/southbridge/intel/i82801gx/i82801gx_smi.c index 636d2eb..c8b5a16 100644 --- a/src/southbridge/intel/i82801gx/i82801gx_smi.c +++ b/src/southbridge/intel/i82801gx/i82801gx_smi.c @@ -81,17 +81,17 @@ extern unsigned int smm_len; static u16 pmbase = DEFAULT_PMBASE; /** - * @brief read and clear PM1_STS + * @brief read and clear PM1_STS * @return PM1_STS register */ static u16 reset_pm1_status(void) { u16 reg16; - + reg16 = inw(pmbase + PM1_STS); /* set status bits are cleared by writing 1 to them */ outw(reg16, pmbase + PM1_STS); - + return reg16; } @@ -110,17 +110,17 @@ static void dump_pm1_status(u16 pm1_sts) } /** - * @brief read and clear SMI_STS + * @brief read and clear SMI_STS * @return SMI_STS register */ static u32 reset_smi_status(void) { u32 reg32; - + reg32 = inl(pmbase + SMI_STS); /* set status bits are cleared by writing 1 to them */ outl(reg32, pmbase + SMI_STS); - + return reg32; } @@ -158,11 +158,11 @@ static void dump_smi_status(u32 smi_sts) static u32 reset_gpe0_status(void) { u32 reg32; - + reg32 = inl(pmbase + GPE0_STS); /* set status bits are cleared by writing 1 to them */ outl(reg32, pmbase + GPE0_STS); - + return reg32; } @@ -191,20 +191,20 @@ static void dump_gpe0_status(u32 gpe0_sts) } /** - * @brief read and clear TCOx_STS + * @brief read and clear TCOx_STS * @return TCOx_STS registers */ static u32 reset_tco_status(void) { u32 tcobase = pmbase + 0x60; u32 reg32; - + reg32 = inl(tcobase + 0x04); /* set status bits are cleared by writing 1 to them */ outl(reg32 & ~(1<<18), tcobase + 0x04); // Don't clear BOOT_STS before SECOND_TO_STS if (reg32 & (1 << 18)) outl(reg32 & (1<<18), tcobase + 0x04); // clear BOOT_STS - + return reg32; } @@ -236,7 +236,7 @@ static void dump_tco_status(u32 tco_sts) static void smi_set_eos(void) { u8 reg8; - + reg8 = inb(pmbase + SMI_EN); reg8 |= EOS; outb(reg8, pmbase + SMI_EN); @@ -286,8 +286,8 @@ void smm_relocate(void) * - Writes to io 0xb2 (APMC) * - Writes to the Local Apic ICR with Delivery mode SMI. * - * Using the local apic is a bit more tricky. According to - * AMD Family 11 Processor BKDG no destination shorthand must be + * Using the local apic is a bit more tricky. According to + * AMD Family 11 Processor BKDG no destination shorthand must be * used. * The whole SMM initialization is quite a bit hardware specific, so * I'm not too worried about the better of the methods at the moment diff --git a/src/southbridge/intel/i82801gx/i82801gx_smihandler.c b/src/southbridge/intel/i82801gx/i82801gx_smihandler.c index 6e6885e..56ce0fe 100644 --- a/src/southbridge/intel/i82801gx/i82801gx_smihandler.c +++ b/src/southbridge/intel/i82801gx/i82801gx_smihandler.c @@ -102,17 +102,17 @@ void *tcg = (void *)0x0; void *smi1 = (void *)0x0; /** - * @brief read and clear PM1_STS + * @brief read and clear PM1_STS * @return PM1_STS register */ static u16 reset_pm1_status(void) { u16 reg16; - + reg16 = inw(pmbase + PM1_STS); /* set status bits are cleared by writing 1 to them */ outw(reg16, pmbase + PM1_STS); - + return reg16; } @@ -131,17 +131,17 @@ static void dump_pm1_status(u16 pm1_sts) } /** - * @brief read and clear SMI_STS + * @brief read and clear SMI_STS * @return SMI_STS register */ static u32 reset_smi_status(void) { u32 reg32; - + reg32 = inl(pmbase + SMI_STS); /* set status bits are cleared by writing 1 to them */ outl(reg32, pmbase + SMI_STS); - + return reg32; } @@ -179,11 +179,11 @@ static void dump_smi_status(u32 smi_sts) static u32 reset_gpe0_status(void) { u32 reg32; - + reg32 = inl(pmbase + GPE0_STS); /* set status bits are cleared by writing 1 to them */ outl(reg32, pmbase + GPE0_STS); - + return reg32; } @@ -213,20 +213,20 @@ static void dump_gpe0_status(u32 gpe0_sts) /** - * @brief read and clear TCOx_STS + * @brief read and clear TCOx_STS * @return TCOx_STS registers */ static u32 reset_tco_status(void) { u32 tcobase = pmbase + 0x60; u32 reg32; - + reg32 = inl(tcobase + 0x04); /* set status bits are cleared by writing 1 to them */ outl(reg32 & ~(1<<18), tcobase + 0x04); // Don't clear BOOT_STS before SECOND_TO_STS if (reg32 & (1 << 18)) outl(reg32 & (1<<18), tcobase + 0x04); // clear BOOT_STS - + return reg32; } @@ -296,7 +296,7 @@ static void southbridge_smi_sleep(unsigned int node, smm_state_save_area_t *stat u8 reg8; u32 reg32; u8 slp_typ; - /* FIXME: the power state on boot should be read from + /* FIXME: the power state on boot should be read from * CMOS or even better from GNVS. Right now it's hard * coded at compile time. */ @@ -347,7 +347,7 @@ static void southbridge_smi_sleep(unsigned int node, smm_state_save_area_t *stat } /* Write back to the SLP register to cause the originally intended - * event again. We need to set BIT13 (SLP_EN) though to make the + * event again. We need to set BIT13 (SLP_EN) though to make the * sleep happen. */ outl(reg32 | SLP_EN, pmbase + PM1_CNT); @@ -545,7 +545,7 @@ static void southbridge_smi_monitor(unsigned int node, smm_state_save_area_t *st #undef IOTRAP } -typedef void (*smi_handler)(unsigned int node, +typedef void (*smi_handler)(unsigned int node, smm_state_save_area_t *state_save); smi_handler southbridge_smi[32] = { @@ -580,7 +580,7 @@ smi_handler southbridge_smi[32] = { NULL, // [28] reserved NULL, // [29] reserved NULL, // [30] reserved - NULL // [31] reserved + NULL // [31] reserved }; /** @@ -601,14 +601,14 @@ void southbridge_smi_handler(unsigned int node, smm_state_save_area_t *state_sav * happening in the following calls. */ smi_sts = reset_smi_status(); - + /* Filter all non-enabled SMI events */ // FIXME Double check, this clears MONITOR // smi_sts &= inl(pmbase + SMI_EN); /* Call SMI sub handler for each of the status bits */ for (i = 0; i < 31; i++) { - if (smi_sts & (1 << i)) { + if (smi_sts & (1 << i)) { if (southbridge_smi[i]) southbridge_smi[i](node, state_save); else { |