diff options
author | Richard Purdie <richard.purdie@linuxfoundation.org> | 2011-08-30 16:46:46 +0000 |
---|---|---|
committer | Richard Purdie <richard.purdie@linuxfoundation.org> | 2011-08-31 19:38:22 +0100 |
commit | 64327ba9ea1d1cefab1bc35d456da68bc061dcf5 (patch) | |
tree | 41e6b8ce6dd6d9e3dfa2d5a92c80e3ac20d58e31 /bitbake | |
parent | 8a78ed689daa9a0eab0ff9e0c4d1ac5fc0b520a9 (diff) | |
download | ast2050-yocto-poky-64327ba9ea1d1cefab1bc35d456da68bc061dcf5.zip ast2050-yocto-poky-64327ba9ea1d1cefab1bc35d456da68bc061dcf5.tar.gz |
bitbake: Correctly handle multiline comments including whitespace
If metadata contains:
"""
FOO = "bar"
"""
The variable FOO should get set to "bar" but doesn't due to the empty lines
be swallowed by the parser and FOO becomming part of the multiline comment.
This patch corrects that behaviour so FOO is set as expected.
[YOCTO #1377]
This patch fixes parsing of multiline comments so lines ending with \
behave consistently and we warn users where there is something happening
they likely don't expect.
(Bitbake rev: 30eaef7f50fff855cf8830772a7088dd83a4240e)
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
Diffstat (limited to 'bitbake')
-rw-r--r-- | bitbake/lib/bb/parse/parse_py/BBHandler.py | 12 |
1 files changed, 6 insertions, 6 deletions
diff --git a/bitbake/lib/bb/parse/parse_py/BBHandler.py b/bitbake/lib/bb/parse/parse_py/BBHandler.py index 402cd07..c59b468 100644 --- a/bitbake/lib/bb/parse/parse_py/BBHandler.py +++ b/bitbake/lib/bb/parse/parse_py/BBHandler.py @@ -194,21 +194,21 @@ def feeder(lineno, s, fn, root, statements): return - # Skip empty lines - if s == '': - return - - if s[0] == '#': + if s and s[0] == '#': if len(__residue__) != 0 and __residue__[0][0] != "#": bb.error("There is a comment on line %s of file %s (%s) which is in the middle of a multiline expression.\nBitbake used to ignore these but no longer does so, please fix your metadata as errors are likely as a result of this change." % (lineno, fn, s)) - if s[-1] == '\\': + if s and s[-1] == '\\': __residue__.append(s[:-1]) return s = "".join(__residue__) + s __residue__ = [] + # Skip empty lines + if s == '': + return + # Skip comments if s[0] == '#': return |