diff options
author | Richard Purdie <richard.purdie@linuxfoundation.org> | 2013-02-03 16:51:34 +0000 |
---|---|---|
committer | Richard Purdie <richard.purdie@linuxfoundation.org> | 2013-02-15 15:53:41 +0000 |
commit | f7836b129954244937d5d20c090fb9c5a7e9f61d (patch) | |
tree | e450b2a26de553a4cd5a5625340f15bff54cecdf | |
parent | 5da2485717b1a32c7a880e500a4251c67ef713ea (diff) | |
download | ast2050-yocto-poky-f7836b129954244937d5d20c090fb9c5a7e9f61d.zip ast2050-yocto-poky-f7836b129954244937d5d20c090fb9c5a7e9f61d.tar.gz |
bitbake: utils: Use rm -rf in remove()
Whilst shutils.rmtree() is pythonic, its also slow. Its faster to
use rm -rf which makes optimial use of the right syscalls.
(Bitbake rev: 96088ebdec08e49ba9e8dbcac437bfcdc21f5983)
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
-rw-r--r-- | bitbake/lib/bb/utils.py | 11 |
1 files changed, 7 insertions, 4 deletions
diff --git a/bitbake/lib/bb/utils.py b/bitbake/lib/bb/utils.py index b1a0f25..8c363df 100644 --- a/bitbake/lib/bb/utils.py +++ b/bitbake/lib/bb/utils.py @@ -535,14 +535,17 @@ def remove(path, recurse=False): """Equivalent to rm -f or rm -rf""" if not path: return - import os, errno, shutil, glob + if recurse: + import subprocess + # shutil.rmtree(name) would be ideal but its too slow + subprocess.call("rm -rf %s" % path, shell=True) + return + import os, errno, glob for name in glob.glob(path): try: os.unlink(name) except OSError as exc: - if recurse and exc.errno == errno.EISDIR: - shutil.rmtree(name) - elif exc.errno != errno.ENOENT: + if exc.errno != errno.ENOENT: raise def prunedir(topdir): |