diff options
| author | Joshua Lock <josh@linux.intel.com> | 2011-07-18 16:22:18 -0700 |
|---|---|---|
| committer | Richard Purdie <richard.purdie@linuxfoundation.org> | 2011-07-26 20:15:47 +0100 |
| commit | 40f0e6dbd4ff449e517c5eb6161cf734d7b64c64 (patch) | |
| tree | c0c0aec95d6aa7ea7868011d2b130eed93619b1c | |
| parent | 2d608f837d51c900dacadeb9737fbde068578d8a (diff) | |
| download | ast2050-yocto-poky-40f0e6dbd4ff449e517c5eb6161cf734d7b64c64.zip ast2050-yocto-poky-40f0e6dbd4ff449e517c5eb6161cf734d7b64c64.tar.gz | |
ui/hob: don't offer to show built output if build fails
The link to open the deploy directory should only be shown if the build
completed succesfully.
(Bitbake rev: d947f9880c2205be66fbd61cf7d3728275979a56)
Signed-off-by: Joshua Lock <josh@linux.intel.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
| -rw-r--r-- | bitbake/lib/bb/ui/hob.py | 10 |
1 files changed, 7 insertions, 3 deletions
diff --git a/bitbake/lib/bb/ui/hob.py b/bitbake/lib/bb/ui/hob.py index 654d2df..e0380dd 100644 --- a/bitbake/lib/bb/ui/hob.py +++ b/bitbake/lib/bb/ui/hob.py @@ -57,6 +57,7 @@ class MainWindow (gtk.Window): self.layers = layers self.save_path = None self.dirty = False + self.build_succeeded = False self.connect("delete-event", self.destroy_window) self.set_title("Image Creator") @@ -65,6 +66,7 @@ class MainWindow (gtk.Window): self.build = RunningBuild() self.build.connect("build-failed", self.running_build_failed_cb) + self.build.connect("build-succeeded", self.running_build_succeeded_cb) self.build.connect("build-started", self.build_started_cb) self.build.connect("build-complete", self.build_complete_cb) @@ -113,9 +115,11 @@ class MainWindow (gtk.Window): def scroll_tv_cb(self, model, path, it, view): view.scroll_to_cell(path) + def running_build_succeeded_cb(self, running_build): + self.build_succeeded = True + def running_build_failed_cb(self, running_build): - # FIXME: handle this - print("Build failed") + self.build_succeeded = False def image_changed_string_cb(self, model, new_image): cnt = 0 @@ -408,7 +412,7 @@ class MainWindow (gtk.Window): os.remove(f) lbl = "<b>Build completed</b>\n\nClick 'Edit Image' to start another build or 'View Log' to view the build log." - if self.handler.building == "image": + if self.handler.building == "image" and self.build_succeeded: deploy = self.handler.get_image_deploy_dir() lbl = lbl + "\n<a href=\"file://%s\" title=\"%s\">Browse folder of built images</a>." % (deploy, deploy) |
