path: root/sst49lfxxxc.c
diff options
authorCarl-Daniel Hailfinger <>2010-10-10 14:02:27 +0000
committerCarl-Daniel Hailfinger <>2010-10-10 14:02:27 +0000
commitb30a5ed4afead1592224009230ea23500f91b230 (patch)
tree0185573277197cab68874cedd1e00246ea2cf573 /sst49lfxxxc.c
parentb28349f8bc40dd55524113e258b3185711e80366 (diff)
Unify chip write functions
The currently used write functions (wrappers) all use helpers which perform the actual write (inner functions). The signature of the write wrappers is: int write_chip(struct flashchip *flash, uint8_t * buf); The signature of the inner write functions varied a lot. This patch changes them to: int write_part(struct flashchip *flash, uint8_t *src, int start, int len); Did you know that flashrom has only 8 inner write functions for all flash chips? write_page_write_jedec_common write_sector_jedec_common write_sector_28sf040 spi_chip_write_256_new spi_chip_write_1_new spi_aai_write_new write_page_82802ab write_page_m29f400bt Export all inner write functions. Change the function signature of wait_82802ab to eliminate single-use variables. Remove an error message in write_page_m29f400bt which was printed for every byte written regardless of success. Add sharplhf00l04.c to the list of flash chip drivers in the Makefile. While the functions in there are unused, I suspect we will need them later, and by hooking the file up we ensure that compilation won't break. Corresponding to flashrom svn r1208. Signed-off-by: Carl-Daniel Hailfinger <> Acked-by: Uwe Hermann <>
Diffstat (limited to 'sst49lfxxxc.c')
1 files changed, 2 insertions, 4 deletions
diff --git a/sst49lfxxxc.c b/sst49lfxxxc.c
index a6571ef..ec7d3da 100644
--- a/sst49lfxxxc.c
+++ b/sst49lfxxxc.c
@@ -67,7 +67,7 @@ int erase_sector_49lfxxxc(struct flashchip *flash, unsigned int address, unsigne
chip_writeb(0x30, bios);
chip_writeb(0xD0, bios + address);
- status = wait_82802ab(bios);
+ status = wait_82802ab(flash);
if (check_erased_range(flash, address, sector_size)) {
msg_cerr("ERASE FAILED!\n");
@@ -85,9 +85,7 @@ int write_49lfxxxc(struct flashchip *flash, uint8_t *buf)
write_lockbits_49lfxxxc(flash, 0);
for (i = 0; i < total_size / page_size; i++) {
- /* write to the sector */
- write_page_82802ab(bios, buf + i * page_size,
- bios + i * page_size, page_size);
+ write_page_82802ab(flash, buf + i * page_size, i * page_size, page_size);
chip_writeb(0xFF, bios);
OpenPOWER on IntegriCloud