diff options
author | Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006@gmx.net> | 2009-06-13 12:04:03 +0000 |
---|---|---|
committer | Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006@gmx.net> | 2009-06-13 12:04:03 +0000 |
commit | 38a059d6ef1ebb7145a04825fec0ebef1d8a66a7 (patch) | |
tree | 66c9108eda2f0f7129f2ba55b9cb757414d9466a /spi.c | |
parent | 8b2f46b878a952a0ea0869624636cb4d6f5fa8c1 (diff) | |
download | ast2050-flashrom-38a059d6ef1ebb7145a04825fec0ebef1d8a66a7.zip ast2050-flashrom-38a059d6ef1ebb7145a04825fec0ebef1d8a66a7.tar.gz |
Every SPI host controller implemented its own way to read flash chips
This was partly due to a design problem in the abstraction layer.
There should be exactly two different functions for reading SPI chips:
- memory mapped reads
- SPI command reads.
Each of them should be contained in a separate function, optionally
taking parameters where needed.
This patch solves the problems mentioned above, shortens the code and
makes the code logic a lot more obvious.
Since open-coding the min() function leads to errors, include it in this
patch as well.
Corresponding to flashrom svn r589.
Signed-off-by: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006@gmx.net>
Acked-by: Ronald G. Minnich <rminnich@gmail.com>
Diffstat (limited to 'spi.c')
-rw-r--r-- | spi.c | 27 |
1 files changed, 27 insertions, 0 deletions
@@ -673,6 +673,33 @@ int spi_nbyte_read(int address, uint8_t *bytes, int len) return spi_command(sizeof(cmd), len, cmd, bytes); } +/* + * Read a complete flash chip. + * Each page is read separately in chunks with a maximum size of chunksize. + */ +int spi_read_chunked(struct flashchip *flash, uint8_t *buf, int chunksize) +{ + int rc = 0; + int i, j; + int total_size = flash->total_size * 1024; + int page_size = flash->page_size; + int toread; + + for (j = 0; j < total_size / page_size; j++) { + for (i = 0; i < page_size; i += chunksize) { + toread = min(chunksize, page_size - i); + rc = spi_nbyte_read(j * page_size + i, + buf + j * page_size + i, toread); + if (rc) + break; + } + if (rc) + break; + } + + return rc; +} + int spi_chip_read(struct flashchip *flash, uint8_t *buf) { switch (spi_controller) { |