path: root/serial.c
diff options
authorNiklas Söderlund <>2012-09-07 07:07:07 +0000
committerStefan Tauner <>2012-09-07 07:07:07 +0000
commit7145a50f5315c2f2a04d31c4d93e8e1387c9948d (patch)
tree1b0eeb996e3bab8ee51af96ae9b0a5c007d095ee /serial.c
parentd932fd0d8cad0c185b7167e44512c9d1f10af52f (diff)
Remove exit calls from sp_sync_read_timeout and sp_synchronize
Add return values to sp_synchronize so we can signal a failure to the only upstream caller (serprog_init), which is prepared to propagate a failure. sp_sync_read_timeout was harder to fix because it already used a return value, but we needed to distinguish two different failure modes. This solution distinguishes them by the sign of the return values, which maintains readability as much as possible. Thanks to Niklas Söderlund for the original patch and idea. Corresponding to flashrom svn r1595. Signed-off-by: Niklas Söderlund <> Signed-off-by: Stefan Tauner <> Acked-by: Stefan Tauner <>
Diffstat (limited to 'serial.c')
1 files changed, 1 insertions, 0 deletions
diff --git a/serial.c b/serial.c
index 05c7d04..7e47dcc 100644
--- a/serial.c
+++ b/serial.c
@@ -239,6 +239,7 @@ void sp_flush_incoming(void)
#ifdef _WIN32
PurgeComm(sp_fd, PURGE_RXCLEAR);
+ /* FIXME: error handling */
tcflush(sp_fd, TCIFLUSH);
OpenPOWER on IntegriCloud