diff options
| author | Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006@gmx.net> | 2010-05-30 22:24:40 +0000 |
|---|---|---|
| committer | Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006@gmx.net> | 2010-05-30 22:24:40 +0000 |
| commit | 831e8f4abb29f1ff66ebb8ab5ff496050ff677f7 (patch) | |
| tree | 8d19ef4871587dcaf0a3a1dec562dd6ef09024b6 /physmap.c | |
| parent | 4178760241c3b3dc46a806ee3621a2eb97f4cca5 (diff) | |
| download | ast2050-flashrom-831e8f4abb29f1ff66ebb8ab5ff496050ff677f7.zip ast2050-flashrom-831e8f4abb29f1ff66ebb8ab5ff496050ff677f7.tar.gz | |
Remove unneeded #include statements completely
Unistd.h was only used to get a definition of NULL in all files. Add our
own NULL #define and remove unistd.h from flash.h
stdio.h has no place in flash.h, it should be included only in files
which really need it.
Add #include statements in individual .c files where needed.
Replace a few printf with msg_* to eliminate the need for stdio.h.
Corresponding to flashrom svn r1021.
Signed-off-by: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006@gmx.net>
Acked-by: Uwe Hermann <uwe@hermann-uwe.de>
Diffstat (limited to 'physmap.c')
| -rw-r--r-- | physmap.c | 10 |
1 files changed, 6 insertions, 4 deletions
@@ -20,6 +20,8 @@ * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA */ +#include <unistd.h> +#include <stdio.h> #include <sys/types.h> #include <sys/stat.h> #include <fcntl.h> @@ -310,8 +312,8 @@ int wrmsr(int addr, msr_t msr) int setup_cpu_msr(int cpu) { char msrfilename[64]; - memset(msrfilename, 0, 64); - sprintf(msrfilename, "/dev/cpu/%d/msr", cpu); + memset(msrfilename, 0, sizeof(msrfilename)); + snprintf(msrfilename, sizeof(msrfilename), "/dev/cpu/%d/msr", cpu); if (fd_msr != -1) { msg_pinfo("MSR was already initialized\n"); @@ -393,8 +395,8 @@ int wrmsr(int addr, msr_t msr) int setup_cpu_msr(int cpu) { char msrfilename[64]; - memset(msrfilename, 0, 64); - sprintf(msrfilename, "/dev/cpu%d", cpu); + memset(msrfilename, 0, sizeof(msrfilename)); + snprintf(msrfilename, sizeof(msrfilename), "/dev/cpu%d", cpu); if (fd_msr != -1) { msg_pinfo("MSR was already initialized\n"); |
