path: root/nicnatsemi.c
diff options
authorCarl-Daniel Hailfinger <>2010-07-03 11:02:10 +0000
committerCarl-Daniel Hailfinger <>2010-07-03 11:02:10 +0000
commitad3cc55e139b2e239325815464fe5f7d828aa794 (patch)
tree46568cf766d19740418be5ca8eaa494c7e69cc36 /nicnatsemi.c
parentb63b067ae22803689592db482611093b33a29eef (diff)
Kill global variables, constants and functions if local scope suffices
Constify variables where possible. Initialize programmer-related variables explicitly in programmer_init to allow running programmer_init from a clean state after programmer_shutdown. Prohibit registering programmer shutdown functions before init or after shutdown. Kill some dead code. Rename global variables with namespace-polluting names. Use a previously unused locking helper function in sst49lfxxxc.c. This is needed for libflashrom. Effects on the binary size of flashrom are minimal (300 bytes shrinkage), but the data section shrinks by 4384 bytes, and that's a good thing if flashrom is operating in constrained envionments. Corresponding to flashrom svn r1068. Signed-off-by: Carl-Daniel Hailfinger <> Acked-by: Michael Karcher <>
Diffstat (limited to 'nicnatsemi.c')
1 files changed, 1 insertions, 1 deletions
diff --git a/nicnatsemi.c b/nicnatsemi.c
index 1878f51..f2e99e3 100644
--- a/nicnatsemi.c
+++ b/nicnatsemi.c
@@ -28,7 +28,7 @@
#define BOOT_ROM_ADDR 0x50
#define BOOT_ROM_DATA 0x54
-struct pcidev_status nics_natsemi[] = {
+const struct pcidev_status nics_natsemi[] = {
{0x100b, 0x0020, NT, "National Semiconductor", "DP83815/DP83816"},
{0x100b, 0x0022, NT, "National Semiconductor", "DP83820"},
OpenPOWER on IntegriCloud