path: root/buspirate_spi.c
diff options
authorCarl-Daniel Hailfinger <>2010-07-03 11:02:10 +0000
committerCarl-Daniel Hailfinger <>2010-07-03 11:02:10 +0000
commitad3cc55e139b2e239325815464fe5f7d828aa794 (patch)
tree46568cf766d19740418be5ca8eaa494c7e69cc36 /buspirate_spi.c
parentb63b067ae22803689592db482611093b33a29eef (diff)
Kill global variables, constants and functions if local scope suffices
Constify variables where possible. Initialize programmer-related variables explicitly in programmer_init to allow running programmer_init from a clean state after programmer_shutdown. Prohibit registering programmer shutdown functions before init or after shutdown. Kill some dead code. Rename global variables with namespace-polluting names. Use a previously unused locking helper function in sst49lfxxxc.c. This is needed for libflashrom. Effects on the binary size of flashrom are minimal (300 bytes shrinkage), but the data section shrinks by 4384 bytes, and that's a good thing if flashrom is operating in constrained envionments. Corresponding to flashrom svn r1068. Signed-off-by: Carl-Daniel Hailfinger <> Acked-by: Michael Karcher <>
Diffstat (limited to 'buspirate_spi.c')
1 files changed, 2 insertions, 2 deletions
diff --git a/buspirate_spi.c b/buspirate_spi.c
index 281a5f5..1bf1d58 100644
--- a/buspirate_spi.c
+++ b/buspirate_spi.c
@@ -30,7 +30,7 @@
-int buspirate_serialport_setup(char *dev)
+static int buspirate_serialport_setup(char *dev)
/* 115200bps, 8 databits, no parity, 1 stopbit */
sp_fd = sp_openserport(dev, 115200);
@@ -44,7 +44,7 @@ int buspirate_serialport_setup(char *dev)
#define sp_flush_incoming(...) 0
-int buspirate_sendrecv(unsigned char *buf, unsigned int writecnt, unsigned int readcnt)
+static int buspirate_sendrecv(unsigned char *buf, unsigned int writecnt, unsigned int readcnt)
int i, ret = 0;
OpenPOWER on IntegriCloud