summaryrefslogtreecommitdiffstats
path: root/usr.sbin/pw
Commit message (Collapse)AuthorAgeFilesLines
* MFC r318141, r318143-r318144asomers2017-05-301-1/+5
| | | | | | | | | | | | | | | | | | | | | | | r318141: strcpy => strlcpy Reported by: Coverity CID: 1352771 Sponsored by: Spectra Logic Corp r318143: strcpy => strlcpy Reported by: Coverity CID: 1006715 Sponsored by: Spectra Logic Corp r318144: Don't depend on assert(3) getting evaluated Reported by: imp X-MFC-With: 318141, 318143 Sponsored by: Spectra Logic Corp
* MFC r315041asomers2017-04-021-0/+1
| | | | | | | | | | | Increase WARNS for pw tests ATF tests have a default WARNS of 0, unlike other usermode programs. Reviewed by: ngie, julian MFC after: 3 weeks Sponsored by: Spectra Logic Corporation Differential Revision: https://reviews.freebsd.org/D9933
* MFC: r315912 (by eugen@) and r315935bapt2017-04-012-2/+19
| | | | | | | | | | Properly initialise with content of pw.conf(5) that was mistakenly ignored. Also, respect "defaultgroup" if specified there. Add a regression test PR: 217934 Reported by: Victor Sudakov <vas@mpeks.tomsk.su>
* MFC r315776:ngie2017-03-3011-10/+10
| | | | | | | | Rename tests from <foo> to <foo>_test to match the FreeBSD test suite naming scheme usr.bin/diff/diff_test was renamed to usr.bin/diff/netbsd_diff_test to avoid collisions with the renamed FreeBSD test.
* MFC r312644, r312650bapt2017-01-283-10/+25
| | | | | | | | | | | | | | | | | | | | | | r312644: Readd a feature lost in pw(8) refactoring pw usermod foo -m It used to be able to (re)create the home directory if it didn't exists PR: 216224 Reported by: ae MFC after: 3 days r312650: Really restore the old behaviour for pw usermod -m It again reinstall missing skel files without overwriting changed one Add a regression test about it Reported by: ae MFC after: 3 days
* MFC r308806asomers2016-12-163-0/+3
| | | | | | | | | | Speed up pw operations that edit /etc/group or /etc/passwd r285050 fixed a bug in pw that could lead to /etc/passwd or /etc/group corruption on power loss. However, it fixed it by opening those files with O_SYNC, which is very slow, especially on ZFS. This change replaces O_SYNC with appropriately placed fsync()s instead, which is much faster. Using a ZFS tmpdir, the time to run pw's kyua tests drops from 245s to 35s.
* MFC r309803:bapt2016-12-121-1/+1
| | | | | | | Fix pw groupshow <gid> PR: 204676 Submitted by: longwitz@incore.de
* MFC r307752asomers2016-11-183-0/+8
| | | | Close some file descriptor leaks in pw
* MFC r302778asomers2016-09-127-15/+177
| | | | | | | | | | | | | | | | | | | | | pw should sanitize the argument of -w. Otherwise, it will silently disable the login for the selected account if the argument is unrecognizable. usr.sbin/pw/pw.h usr.sbin/pw/pw_conf.c usr.sbin/pw/pw_user.c Use separate rules to validate boolean parameters and passwd parameters. Error out if a password parameter cannot be parsed. usr.sbin/pw/tests/Makefile usr.sbin/pw/tests/crypt.c usr.sbin/pw/tests/pw_useradd.sh usr.sbin/pw/tests/pw_usermod.sh Add tests for the validation. Also, enhance existing password-related tests to actually validate that the correct hash is written to master.passwd.
* iDo not try to delete the home of the user if is is not a directory for examplebapt2016-07-242-0/+12
| | | | | | | | | "/dev/null" PR: 211195 Submitted by: rday <ryan@ryanday.net> Reported by: eniorm <eniorm@gmail.com> Approved by: re (kib)
* Fix typo preventing pw {user,group}next -C from working as expectedbapt2016-06-042-2/+2
| | | | | Reported by: Mike Selnet via forums.freebsd.org MFC after: 3 days
* Fix CID 1006692 in /usr/sbin/pw pw_log() function and other fixestruckman2016-05-241-21/+71
| | | | | | | | | | | | | | | | | | | | | | | | | | The length of the name returned from the $LOGNAME and $USER can be very long and it was being concatenated to a fixed length buffer with no bounds checking. Fix this problem by limiting the length of the name copied. Additionally, this name is actually used to create a format string to be used in adding log file entries so embedded % characters in the name could confuse *printf(), and embedded whitespace could confuse a log file parser. Handle the former by escaping each % with an additional %, and handle the latter by simply stripping it out. Clean up the code by moving the variable declarations to the top of the function, formatting them to conform with style, and moving intialization elsewhere. Reduce code indentation by returning early in a couple of places. Reported by: Coverity CID: 1006692 Reviewed by: markj (previous version) MFC after: 2 weeks Differential Revision: https://reviews.freebsd.org/D6490
* Merge ^/user/ngie/release-pkg-fix-tests to unbreak how test files are installedngie2016-05-041-5/+5
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | after r298107 Summary of changes: - Replace all instances of FILES/TESTS with ${PACKAGE}FILES. This ensures that namespacing is kept with FILES appropriately, and that this shouldn't need to be repeated if the namespace changes -- only the definition of PACKAGE needs to be changed - Allow PACKAGE to be overridden by callers instead of forcing it to always be `tests`. In the event we get to the point where things can be split up enough in the base system, it would make more sense to group the tests with the blocks they're a part of, e.g. byacc with byacc-tests, etc - Remove PACKAGE definitions where possible, i.e. where FILES wasn't used previously. - Remove unnecessary TESTSPACKAGE definitions; this has been elided into bsd.tests.mk - Remove unnecessary BINDIRs used previously with ${PACKAGE}FILES; ${PACKAGE}FILESDIR is now automatically defined in bsd.test.mk. - Fix installation of files under data/ subdirectories in lib/libc/tests/hash and lib/libc/tests/net/getaddrinfo - Remove unnecessary .include <bsd.own.mk>s (some opportunistic cleanup) Document the proposed changes in share/examples/tests/tests/... via examples so it's clear that ${PACKAGES}FILES is the suggested way forward in terms of replacing FILES. share/mk/bsd.README didn't seem like the appropriate method of communicating that info. MFC after: never probably X-MFC with: r298107 PR: 209114 Relnotes: yes Tested with: buildworld, installworld, checkworld; buildworld, packageworld Sponsored by: EMC / Isilon Storage Division
* Add a single example of adding a user that roughly corresponds with thewblock2016-04-231-1/+13
| | | | | | adduser example in the Handbook. MFC after: 1 week
* MFHgjb2016-04-045-18/+9
|\ | | | | | | Sponsored by: The FreeBSD Foundation
| * Adjust misleading wording of the -G option and simplify a fewwblock2016-03-281-11/+9
| | | | | | | | | | | | surrounding sentences. From a discussion on -ports. Reviewed by: David Wolfskill <david@catwhisker.org>
| * Remove some unneeded headersbapt2016-03-264-7/+0
| | | | | | | | Found by 'include-what-you-use'
* | MFHgjb2016-03-101-0/+11
|\ \ | |/ | | | | Sponsored by: The FreeBSD Foundation
| * DIRDEPS_BUILD: Connect MK_TESTS.bdrewery2016-03-091-0/+11
| | | | | | | | Sponsored by: EMC / Isilon Storage Division
* | MFHgjb2016-03-021-1/+1
|\ \ | |/ | | | | Sponsored by: The FreeBSD Foundation
| * Fix a typo that prevented pw(8) from setting a user's UID to 0.markj2016-03-021-1/+1
| | | | | | | | | | MFC after: 1 week Sponsored by: EMC / Isilon Storage Division
* | First pass to fix the 'tests' packages.gjb2016-02-021-0/+4
|/ | | | Sponsored by: The FreeBSD Foundation
* Simplify code for parsing extra groupsbapt2015-12-291-1/+1
|
* Remove useless assignement of linelenbapt2015-12-291-2/+0
|
* Restore dryrun support for pw groupmodbapt2015-12-281-0/+5
|
* pw_checkname since the beginning if too strict on GECOS field,bapt2015-12-021-1/+2
| | | | | | | | | | | relax it a bit so gecos can be used to store multibytes data. This was unseen before FreeBSD 10.2 as this validation function was motly unused since FreeBSD 10.2 the usage of this function has been generalized to improve validation. Reported by: des MFC after: 1 week
* Fix handling of numeric-only names with pw lockbapt2015-12-022-9/+32
| | | | | | | Add a regression test about it PR: 204968 MFC after: 1 week
* In pw_userlock, set 'name' to NULL when we encounter an all number stringdelphij2015-10-301-2/+3
| | | | | | | | because it is also used as an indicator of whether a name or an UID is being used and we may have undefined results as 'name' may contain uninitialized stack contents. MFC after: 2 weeks
* Fix unlikely memory leak.bdrewery2015-10-291-1/+3
| | | | | | | It is unlikely since the first check in the function is that dir[0] is '/', but later code changes may make it real. Coverity CID: 1332104
* Initialize `quiet` to false so `pw groupnext` again prints out the next gidngie2015-10-191-1/+1
| | | | | | | | | by default Reported by: Florian Degner <f.degner@gmx.de> MFC after: 1 week PR: 203876 Sponsored by: EMC / Isilon Storage Division
* Refactor the test/ Makefiles after recent changes to bsd.test.mk (r289158) andngie2015-10-121-2/+0
| | | | | | | | | | | | netbsd-tests.test.mk (r289151) - Eliminate explicit OBJTOP/SRCTOP setting - Convert all ad hoc NetBSD test integration over to netbsd-tests.test.mk - Remove unnecessary TESTSDIR setting - Use SRCTOP where possible for clarity MFC after: 2 weeks Sponsored by: EMC / Isilon Storage Divison
* Fix a repeated typo: rootir -> rootdir.wblock2015-10-091-11/+11
| | | | | Approved by: bapt MFC after: 1 week
* Regression: fix usershow -7bapt2015-09-141-1/+1
| | | | | Submitted by: Dan McGregor (via IRC) MFC after: 2 days
* Regression: fix pw usermod -dbapt2015-09-121-0/+1
| | | | | | | | | Mark the user has having been edited if -d option is passed to usermod and so the request change of home directory actually happen PR: 203052 Reported by: lenzi.sergio@gmail.com MFC after: 2 days
* Fix err pointer not initialized to NULL resultingbapt2015-08-212-0/+16
| | | | Reported by: "O. Hartmann" <ohartman@zedat.fu-berlin.de>
* Fix typo in regression testbapt2015-08-211-1/+1
|
* Fix /home symlink creationbapt2015-08-212-1/+14
| | | | Add regression test about it
* Fix useradd regression:bapt2015-08-212-2/+67
| | | | | | | | Readd the function to create the parents home directory if it does not exists. if it is only a directory at the top level of the hierarchy symlink it into /usr as it used to be done before. Reported by: kevlo, adrian
* Regression: fix pw usermod -w xxxbapt2015-08-142-0/+16
| | | | Reported by: gjb
* Add regression tests for a bug reported in stable/10bapt2015-08-051-0/+9
| | | | | While pw(8) on head is not affected it is worth adding more regression tests ensuring this bug will not happen unnoticed in the futur
* Avoid calling strlen() where we can use the strspn() return value.ed2015-08-032-9/+9
|
* Clarify pw(8) manual w/respect to required arguments. Break long lines atdteske2015-08-031-90/+118
| | | | | | | | | punctuation while here. Differential Revision: https://reviews.freebsd.org/D2700 Reviewed by: wblock, bapt MFC after: 3 days X-MFC-to: stable/10
* Fix bugs spotted by gccbapt2015-08-031-3/+4
| | | | Reported by: adrian
* Actually set quiet to something.adrian2015-08-031-1/+1
| | | | | /usr/home/adrian/work/freebsd/head-embedded-2/src/usr.sbin/pw/pw_user.c: In function 'pw_user_next': /usr/home/adrian/work/freebsd/head-embedded-2/src/usr.sbin/pw/pw_user.c:680: warning: statement with no effect
* Use intmax_t rather than long longbapt2015-08-021-2/+2
|
* Convert the year used for regression test fro 2043 to 2037bapt2015-08-021-11/+11
| | | | This makes the regression tests pass on systems where time_t is 32bits
* Fix build on 32bitsbapt2015-08-021-2/+2
|
* Split some extra long linesbapt2015-08-021-2/+4
|
* Split some extra long linesbapt2015-08-021-5/+10
|
* Cleanup a bit includesbapt2015-08-0212-52/+43
|
OpenPOWER on IntegriCloud