summaryrefslogtreecommitdiffstats
path: root/sbin/iscontrol
Commit message (Collapse)AuthorAgeFilesLines
* MFC r314655:ngie2017-05-301-1/+1
| | | | | | bin: normalize paths using SRCTOP-relative paths or :H when possible This simplifies make logic/output
* Fix multiple Coverity Out-of-bounds access false postive issues in CAMtruckman2016-05-241-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The currently used idiom for clearing the part of a ccb after its header generates one or two Coverity errors for each time it is used. All instances generate an Out-of-bounds access (ARRAY_VS_SINGLETON) error because of the treatment of the header as a two element array, with a pointer to the non-existent second element being passed as the starting address to bzero(). Some instances also alsp generate Out-of-bounds access (OVERRUN) errors, probably because the space being cleared is larger than the sizeofstruct ccb_hdr). In addition, this idiom is difficult for humans to understand and it is error prone. The user has to chose the proper struct ccb_* type (which does not appear in the surrounding code) for the sizeof() in the length calculation. I found several instances where the length was incorrect, which could cause either an actual out of bounds write, or incompletely clear the ccb. A better way is to write the code to clear the ccb itself starting at sizeof(ccb_hdr) bytes from the start of the ccb, and calculate the length based on the specific type of struct ccb_* being cleared as specified by the union ccb member being used. The latter can normally be seen in the nearby code. This is friendlier for Coverity and other static analysis tools because they will see that the intent is to clear the trailing part of the ccb. Wrap all of the boilerplate code in a convenient macro that only requires a pointer to the desired union ccb member (or a pointer to the union ccb itself) as an argument. Reported by: Coverity CID: 1007578, 1008684, 1009724, 1009773, 1011304, 1011306 CID: 1011307, 1011308, 1011309, 1011310, 1011311, 1011312 CID: 1011313, 1011314, 1011315, 1011316, 1011317, 1011318 CID: 1011319, 1011320, 1011321, 1011322, 1011324, 1011325 CID: 1011326, 1011327, 1011328, 1011329, 1011330, 1011374 CID: 1011390, 1011391, 1011392, 1011393, 1011394, 1011395 CID: 1011396, 1011397, 1011398, 1011399, 1011400, 1011401 CID: 1011402, 1011403, 1011404, 1011405, 1011406, 1011408 CID: 1011409, 1011410, 1011411, 1011412, 1011413, 1011414 CID: 1017461, 1018387, 1086860, 1086874, 1194257, 1229897 CID: 1229968, 1306229, 1306234, 1331282, 1331283, 1331294 CID: 1331295, 1331535, 1331536, 1331539, 1331540, 1341623 CID: 1341624, 1341637, 1341638, 1355264, 1355324 Reviewed by: scottl, ken, delphij, imp MFH: 1 month Differential Revision: https://reviews.freebsd.org/D6496
* Rename getline with get_line to avoid collision with getline(3)bapt2016-05-101-2/+2
| | | | | When getline(3) in 2009 was added a _WITH_GETLINE guard has also been added. This rename is made in preparation for the removal of this guard
* Include correct is*ct*l program in iscsi package, and package thegjb2016-02-161-1/+1
| | | | | | | legacy version separately. Submitted by: trasz Sponsored by: The FreeBSD Foundation
* Create packages for atm, ccdconfig, devd, ipf, ipfw,gjb2016-02-091-0/+1
| | | | | | | | iscsi, natd, nandfs, pf, quotacheck, and routed. Add ping6 and rtsol to the runtime package. Sponsored by: The FreeBSD Foundation
* Add META_MODE support.sjg2015-06-131-0/+22
|\ | | | | | | | | | | | | | | | | | | | | Off by default, build behaves normally. WITH_META_MODE we get auto objdir creation, the ability to start build from anywhere in the tree. Still need to add real targets under targets/ to build packages. Differential Revision: D2796 Reviewed by: brooks imp
| * dirdeps.mk now sets DEP_RELDIRsjg2015-06-081-2/+0
| |
| * Merge sync of headsjg2015-05-273-194/+5
| |\ | |/ |/|
| * Merge from head@274682sjg2014-11-191-1/+10
| |\
| * | Updated dependenciessjg2014-05-161-1/+0
| | |
| * | Updated dependenciessjg2014-05-101-0/+2
| | |
| * | Merge headsjg2014-04-282-5/+5
| |\ \
| * \ \ Merge head@256284sjg2013-10-132-31/+8
| |\ \ \
| * | | | Updated dependenciessjg2013-10-131-0/+1
| | | | |
| * | | | Merge from headsjg2013-09-058-20/+10
| |\ \ \ \
| * | | | | Updated dependenciessjg2013-03-111-0/+1
| | | | | |
| * | | | | Updated dependenciessjg2013-02-161-2/+0
| | | | | |
| * | | | | Sync FreeBSD's bmake branch with Juniper's internal bmake branch.marcel2012-08-221-0/+22
| | | | | | | | | | | | | | | | | | | | | | | | Requested by: Simon Gerraty <sjg@juniper.net>
* | | | | | mdoc: remove EOL whitespace.joel2014-12-291-1/+1
| | | | | |
* | | | | | mdoc: improvements to SEE ALSO.joel2014-12-271-2/+2
| | | | | |
* | | | | | Move iscsi.conf.5 from sbin/iscontrol/ to usr.bin/iscsictl/, as thetrasz2014-12-052-189/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | former is obsolete. MFC after: 2 weeks Sponsored by: The FreeBSD Foundation
* | | | | | Convert sbin/ to LIBADDbapt2014-11-251-2/+1
| |_|_|_|/ |/| | | | | | | | | | | | | | Reduce overlinking
* | | | | Mark iscontrol(8) and iscsi_initiator(4) obsolete.trasz2014-10-111-1/+10
| |_|_|/ |/| | | | | | | | | | | | | | | | | | | | | | | Differential Revision: https://reviews.freebsd.org/D931 Reviewed by: wblock@ MFC after: 3 days Sponsored by: The FreeBSD Foundation
* | | | Reword the part about mutual CHAP.trasz2013-12-171-5/+4
| | | | | | | | | | | | | | | | | | | | MFC after: 2 weeks Sponsored by: The FreeBSD Foundation
* | | | Check for EHOSTUNREACH when establishing a connection.kevlo2013-10-171-0/+1
| |_|/ |/| | | | | | | | Reviewed by: trasz
* | | Remove unimplemented options from iscsi.conf(5) manual page, mentiontrasz2013-10-101-31/+6
| | | | | | | | | | | | | | | | | | | | | | | | that it's being used by both initiators, and change the title to make it more easily searchable. Approved by: re (glebius) Sponsored by: FreeBSD Foundation
* | | Bring in the new iSCSI target and initiator.trasz2013-09-142-0/+2
| |/ |/| | | | | | | | | Reviewed by: ken (parts) Approved by: re (delphij) Sponsored by: FreeBSD Foundation
* | Move the old iSCSI initiator source to a more appropriate placetrasz2013-08-227-7/+7
| | | | | | | | | | | | | | | | | | (sys/dev/iscsi_initiator/ instead of sys/dev/iscsi/initiator/), to make room for the new one. This is also more logical location (kernel module being named iscsi_initiator.ko, for example). There is no ongoing work on this I know of, so it shouldn't make life harder for anyone. There are no functional changes, apart from "svn mv" and adjusting paths.
* | mdoc sweep.joel2013-05-121-1/+3
| |
* | Remove includes for old versions of FreeBSD.eadler2013-05-064-12/+0
|/ | | | | | Reviewed by: stass Obtained From: DragonFlyBSD MFC After: 1 week
* General mdoc(7) and typo fixes.gjb2012-05-121-2/+2
| | | | | | PR: 167804 Submitted by: Nobuyuki Koganemaru (kogane!jp.freebsd.org) MFC after: 3 days
* Unbreak tinderbox.jpaetzel2012-04-182-27/+35
| | | | | | | Fix FreeBSD paradigms in the upstream code. PR: bin/166933 Submitted by: Garrett Cooper <yanegomi@gmail.com>
* Update to version 2.3.1.0jpaetzel2012-04-134-4/+22
| | | | Obtained from: Daniel Braniss <danny@cs.huji.ac.il>
* Whitespace cleanup:gjb2012-02-251-4/+4
| | | | | | | | | o Wrap sentences on to new lines o Cleanup trailing whitespace Found with: textproc/igor MFC after: 1 week X-MFC-With: r232157
* Fix various typos in manual pages.gjb2012-02-251-2/+2
| | | | | | Submitted by: amdmi3 PR: 165431 MFC after: 1 week
* Fix compilation with debug on.cracauer2011-01-252-3/+3
| | | | Fix segfault when TargetAddress is missing or mis-spelled in config file.
* - Add full support for header / data digests.des2010-08-0912-243/+142
| | | | | | | | | | | | | - Increase target limit from 4 to 64; this limit will be removed entirely at a later time. - Improve recovery from lost network connections. - Fix some potential deadlocks and a serious memory leak. - Fix incorrect use of MH_ALIGN (instead of M_ALIGN), which makes no practical difference, but triggers a KASSERT with INVARIANTS. - Fix some warnings in iscontrol(8) and improve the man page somewhat. Submitted by: Daniel Braniss <danny@cs.huji.ac.il> Sponsored by: Dansk Scanning A/S, Data Robotics Inc.
* Spelling fixes.joel2010-07-311-1/+1
|
* o Restore missed flag in the synopsis.maxim2010-07-131-1/+1
| | | | | | PR: docs/148534 Submitted by: Warren Block MFC after: 1 week
* Remove dead variable assignmentsuqs2010-06-111-1/+0
| | | | | Found by: clang static analyzer Verified by: md5(1)
* mdoc: order prologue macros consistently by Dd/Dt/Osuqs2010-04-141-1/+1
| | | | | | | | Although groff_mdoc(7) gives another impression, this is the ordering most widely used and also required by mdocml/mandoc. Reviewed by: ru Approved by: philip, ed (mentors)
* pukeText is an internal function so define it as static rather thandelphij2010-02-032-2/+3
| | | | | | exporting it. MFC after: 1 month
* Switch the default WARNS level for sbin/ to 6.ru2009-10-191-0/+1
| | | | Submitted by: Ulrich Spörlein
* Big update to the iSCSI initiator code. Highlights include IPv6 support,scottl2008-11-2510-59/+91
| | | | | | | | | | | | | | | | | | | | | | | | | many bugs fixes, many more performance improvements. Submitted by: Danny Braniss M sbin/iscontrol/iscsi.conf.5 M sbin/iscontrol/iscontrol.8 M sbin/iscontrol/iscontrol.h M sbin/iscontrol/config.c M sbin/iscontrol/fsm.c M sbin/iscontrol/login.c M sbin/iscontrol/pdu.c M sbin/iscontrol/misc.c M sbin/iscontrol/auth_subr.c M sbin/iscontrol/iscontrol.c M sys/dev/iscsi/initiator/isc_cam.c M sys/dev/iscsi/initiator/iscsi.h M sys/dev/iscsi/initiator/isc_soc.c M sys/dev/iscsi/initiator/iscsi_subr.c M sys/dev/iscsi/initiator/iscsivar.h M sys/dev/iscsi/initiator/isc_subr.c M sys/dev/iscsi/initiator/iscsi.c M sys/dev/iscsi/initiator/isc_sm.c
* Fix typo.pb2008-02-061-1/+1
| | | | Submitted by: danny at cs.huji.ac.il (author)
* Update fix from rev 1.2.pb2008-02-061-3/+4
| | | | | Submitted by: danny at cs.huji.ac.il (author) MFC after: 1 week
* Fix a bug in hexadecimal formatting of the CHAP digest: bytes >= 0x80pb2008-02-051-1/+1
| | | | | | | were formatted as 0xff, causing the authentication to fail. Reviewed by: scottl MFC after: 1 week
* First round of cleanups.brueffer2007-07-242-24/+37
| | | | Approved by: re (blanket)
* Introduce Danny Braniss' iSCSI initiator, version 2.0.99. Please read thescottl2007-07-2412-0/+2998
included man pages on how to use it. This code is still somewhat experimental but has been successfully tested on a number of targets. Many thanks to Danny for contributing this. Approved by: re
OpenPOWER on IntegriCloud