diff options
Diffstat (limited to 'contrib/tcpdump/print-vjc.c')
| -rw-r--r-- | contrib/tcpdump/print-vjc.c | 18 |
1 files changed, 14 insertions, 4 deletions
diff --git a/contrib/tcpdump/print-vjc.c b/contrib/tcpdump/print-vjc.c index 24f8a12..3287b9b 100644 --- a/contrib/tcpdump/print-vjc.c +++ b/contrib/tcpdump/print-vjc.c @@ -19,14 +19,17 @@ * MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE. */ -#define NETDISSECT_REWORKED +/* \summary: PPP Van Jacobson compression printer */ + +/* specification: RFC 1144 */ + #ifdef HAVE_CONFIG_H #include "config.h" #endif -#include <tcpdump-stdinc.h> +#include <netdissect-stdinc.h> -#include "interface.h" +#include "netdissect.h" #include "slcompress.h" #include "ppp.h" @@ -71,6 +74,13 @@ * We therefore leave "proto" - which is the PPP protocol type - in place, * *not* marked as unused, for now, so that GCC warnings about the * unused argument remind us that we should fix this some day. + * + * XXX - also, it fetches the TCP checksum field in COMPRESSED_TCP + * packets directly, rather than with EXTRACT_16BITS(); RFC 1144 says + * it's "the unmodified TCP checksum", which would imply that it's + * big-endian, but perhaps, on the platform where this was developed, + * the packets were munged by the networking stack before being handed + * to the packet capture mechanism. */ int vjc_print(netdissect_options *ndo, register const char *bp, u_short proto _U_) @@ -96,7 +106,7 @@ vjc_print(netdissect_options *ndo, register const char *bp, u_short proto _U_) if (bp[1]) ND_PRINT((ndo, " ")); ND_PRINT((ndo, "C=0x%02x ", bp[2])); - ND_PRINT((ndo, "sum=0x%04x ", *(u_short *)&bp[3])); + ND_PRINT((ndo, "sum=0x%04x ", *(const u_short *)&bp[3])); return -1; case TYPE_ERROR: if (ndo->ndo_eflag) |
