diff options
| author | ngie <ngie@FreeBSD.org> | 2016-04-28 17:57:17 +0000 |
|---|---|---|
| committer | ngie <ngie@FreeBSD.org> | 2016-04-28 17:57:17 +0000 |
| commit | 51f1c1e1eb58a7ae2dbda88b8a0be976f295cb1b (patch) | |
| tree | 218d6230f3d57917c5cafdf912740d7b56f60ae7 /usr.sbin | |
| parent | 3db4f9fcfef1566ee54b87cd68e0cfee126737bc (diff) | |
| download | FreeBSD-src-51f1c1e1eb58a7ae2dbda88b8a0be976f295cb1b.zip FreeBSD-src-51f1c1e1eb58a7ae2dbda88b8a0be976f295cb1b.tar.gz | |
Use a better idiom for finding UTC prefixed timezones
Instead of copy-pasting the string literal for "UTC" 3 times and using
strlen, use a static char[3] buffer and sizeof(..).
MFC after: 3 days
X-MFC with: r298507
Submitted by: kib
Sponsored by: EMC / Isilon Storage Division
Diffstat (limited to 'usr.sbin')
| -rw-r--r-- | usr.sbin/bsnmpd/tools/libbsnmptools/bsnmptc.c | 7 |
1 files changed, 4 insertions, 3 deletions
diff --git a/usr.sbin/bsnmpd/tools/libbsnmptools/bsnmptc.c b/usr.sbin/bsnmpd/tools/libbsnmptools/bsnmptc.c index 43dd9a4..a682c80 100644 --- a/usr.sbin/bsnmpd/tools/libbsnmptools/bsnmptc.c +++ b/usr.sbin/bsnmpd/tools/libbsnmptools/bsnmptc.c @@ -338,8 +338,9 @@ static char * snmp_date2asn_oid(char *str, struct asn_oid *oid) { char *endptr, *ptr; - uint32_t v; + static const char UTC[3] = "UTC"; int32_t saved_errno; + uint32_t v; if (snmp_suboid_append(oid, (asn_subid_t) SNMP_DATETIME_OCTETS) < 0) return (NULL); @@ -440,8 +441,8 @@ snmp_date2asn_oid(char *str, struct asn_oid *oid) /* 'UTC' - optional */ ptr = endptr + 1; - if (strncmp(ptr, "UTC", strlen("UTC")) == 0) - ptr += strlen("UTC"); + if (strncmp(ptr, UTC, sizeof(UTC)) == 0) + ptr += sizeof(UTC); /* '+/-' */ if (*ptr == '-' || *ptr == '+') { |
