Don't recurse into datalink_UpdateSet() after

doing a HangupDone().  The HangupDone() may fuel
bundle_CleanDatalinks(), and if so, the bogus
UpdateSet() ends up select()ing on a closed
descriptor.....

Change the main `do/while' loop to a `for' loop so
that any `continue's do the bundle_CleanDatalinks()
& bundle_IsDead() bit.

1 files changed, 2 insertions, 2 deletions

diff --git a/usr.sbin/ppp/main.c b/usr.sbin/ppp/main.c
index 2cce11e..cbe0f55 100644
--- a/usr.sbin/ppp/main.c
+++ b/usr.sbin/ppp/main.c
@@ -506,7 +506,7 @@ DoLoop(struct bundle *bundle)
 
   probe_Init(&probe);
 
-  do {
+  for (; !bundle_IsDead(bundle); bundle_CleanDatalinks(bundle)) {
     nfds = 0;
     FD_ZERO(&rfds);
     FD_ZERO(&wfds);
@@ -619,7 +619,7 @@ DoLoop(struct bundle *bundle)
         t.tv_usec = 100000;
         select(0, NULL, NULL, NULL, &t);
       }
-  } while (bundle_CleanDatalinks(bundle), !bundle_IsDead(bundle));
+  }
 
   log_Printf(LogDEBUG, "DoLoop done.\n");
 }