diff options
| author | brian <brian@FreeBSD.org> | 1997-05-10 01:22:19 +0000 |
|---|---|---|
| committer | brian <brian@FreeBSD.org> | 1997-05-10 01:22:19 +0000 |
| commit | 82bac13560d095243e9988bfb770da73089749c1 (patch) | |
| tree | 262cfd051516c08f29f6f133a950e9de9f2d42fd /usr.sbin/ppp/auth.c | |
| parent | 1da867bda76bc701006945dfbc4733f550c91c2d (diff) | |
| download | FreeBSD-src-82bac13560d095243e9988bfb770da73089749c1.zip FreeBSD-src-82bac13560d095243e9988bfb770da73089749c1.tar.gz | |
Tidy up the code - bounds checking, return
value checking etc.
Submitted by: eivind
Diffstat (limited to 'usr.sbin/ppp/auth.c')
| -rw-r--r-- | usr.sbin/ppp/auth.c | 18 |
1 files changed, 12 insertions, 6 deletions
diff --git a/usr.sbin/ppp/auth.c b/usr.sbin/ppp/auth.c index 4ab98f2..29eb776 100644 --- a/usr.sbin/ppp/auth.c +++ b/usr.sbin/ppp/auth.c @@ -17,7 +17,7 @@ * IMPLIED WARRANTIES, INCLUDING, WITHOUT LIMITATION, THE IMPLIED * WARRANTIES OF MERCHANTIBILITY AND FITNESS FOR A PARTICULAR PURPOSE. * - * $Id: auth.c,v 1.10 1997/02/22 16:10:01 peter Exp $ + * $Id: auth.c,v 1.11 1997/05/07 23:01:21 brian Exp $ * * TODO: * o Implement check against with registered IP addresses. @@ -112,8 +112,12 @@ char *fname, *system, *key; bzero(&DefHisAddress, sizeof(DefHisAddress)); n -= 2; if (n > 0) { - ParseAddr(n--, &vector[2], - &DefHisAddress.ipaddr, &DefHisAddress.mask, &DefHisAddress.width); + if (ParseAddr(n--, &vector[2], + &DefHisAddress.ipaddr, + &DefHisAddress.mask, + &DefHisAddress.width) == 0) { + return(0); /* Invalid */ + } } IpcpInit(); return(1); /* Valid */ @@ -156,9 +160,11 @@ int len, setaddr; #ifdef DEBUG LogPrintf(LOG_LCP_BIT, "*** n = %d, %s\n", n, vector[2]); #endif - ParseAddr(n--, &vector[2], - &DefHisAddress.ipaddr, &DefHisAddress.mask, &DefHisAddress.width); - IpcpInit(); + if (ParseAddr(n--, &vector[2], + &DefHisAddress.ipaddr, + &DefHisAddress.mask, + &DefHisAddress.width) != 0) + IpcpInit(); } return(passwd); } |
