- Change ofwdump(8) to use sysexits(3) exit codes.

- Make the code use the new OFIOCMAXVALUE instead of defining the maximum
  length of property values locally.
- Move the application specific parts from ofw_util.c to ofwdump.c in
  order to make ofw_util.c more library-like. While ofw_dump_properties()
  could be made non-specific to ofwdump(8) it's currently optimized for
  use in ofwdump(8) and making it a library-like function would just
  complicate the code unnecessarily.
- Minor clean-up in ofw_util.c, e.g. make its use of getopt(3) the way
  it's described in style(9), make its usage() static, etc.
- Add a comment in ofw_util.c about why it doesn't call usage() when
  neither the "-a" option nor a node-name where given.
- Add ofw_optnode() and ofw_setprop(), helper functions for the
  OFIOCGETOPTNODE and OFIOCSET ioctls respectively, to ofw_util.[c,h].
- Be consistent with the use of 'const' in ofw_util.[c,h] and add 'const'
  to the function arguments that are acutally const but weren't declared
  as such.
- Mark WARNS=6 clean.

Approved by:	tmm

1 files changed, 5 insertions, 6 deletions

diff --git a/usr.sbin/ofwdump/ofw_util.h b/usr.sbin/ofwdump/ofw_util.h
index c267bb4..af8f01f 100644
--- a/usr.sbin/ofwdump/ofw_util.h
+++ b/usr.sbin/ofwdump/ofw_util.h
@@ -30,22 +30,21 @@
 
 #include <dev/ofw/openfirm.h>
 
-int		ofw_open(void);
+int		ofw_open(int);
 void		ofw_close(int);
 
 phandle_t	ofw_root(int);
+phandle_t	ofw_optnode(int);
 phandle_t	ofw_peer(int, phandle_t);
 phandle_t	ofw_child(int, phandle_t);
-phandle_t	ofw_finddevice(int, char *);
+phandle_t	ofw_finddevice(int, const char *);
 
 int		ofw_firstprop(int, phandle_t, char *, int);
-int		ofw_nextprop(int, phandle_t, char *, char *, int);
+int		ofw_nextprop(int, phandle_t, const char *, char *, int);
 int		ofw_getprop(int, phandle_t, const char *, void *, int);
+int		ofw_setprop(int, phandle_t, const char *, const void *, int);
 int		ofw_getproplen(int, phandle_t, const char *);
 int		ofw_getprop_alloc(int, phandle_t, const char *, void **, int *,
     int);
 
-void		ofw_dump(int, char *, int, int, char *, int, int);
-
 #endif /* OFW_UTIL_H */
-