summaryrefslogtreecommitdiffstats
path: root/usr.sbin/cron/cron/popen.c
diff options
context:
space:
mode:
authorpfg <pfg@FreeBSD.org>2016-01-04 03:20:41 +0000
committerpfg <pfg@FreeBSD.org>2016-01-04 03:20:41 +0000
commitd9222b5f8fb29be6dea4f5d3a49acd3c3818668d (patch)
treeed2024fa036203f89b59b039aaf6da516080c45f /usr.sbin/cron/cron/popen.c
parente239096251e02e9b318a77632b5df90807e2ed61 (diff)
downloadFreeBSD-src-d9222b5f8fb29be6dea4f5d3a49acd3c3818668d.zip
FreeBSD-src-d9222b5f8fb29be6dea4f5d3a49acd3c3818668d.tar.gz
MFC r292605, r292606, r292607, r292608:
cron: bring some fixes for Coverity reports and other issues. crontab: replace malloc + bzero with calloc crontab: properly free an entry cron: Check the return value of pipe(2) CID: 271773, 1009830,
Diffstat (limited to 'usr.sbin/cron/cron/popen.c')
-rw-r--r--usr.sbin/cron/cron/popen.c3
1 files changed, 1 insertions, 2 deletions
diff --git a/usr.sbin/cron/cron/popen.c b/usr.sbin/cron/cron/popen.c
index 428de2e..57b1f77 100644
--- a/usr.sbin/cron/cron/popen.c
+++ b/usr.sbin/cron/cron/popen.c
@@ -82,9 +82,8 @@ cron_popen(program, type, e)
if (!pids) {
if ((fds = getdtablesize()) <= 0)
return(NULL);
- if (!(pids = (PID_T *)malloc((u_int)(fds * sizeof(PID_T)))))
+ if (!(pids = calloc(fds, sizeof(PID_T))))
return(NULL);
- bzero((char *)pids, fds * sizeof(PID_T));
}
if (pipe(pdes) < 0)
return(NULL);
OpenPOWER on IntegriCloud