summaryrefslogtreecommitdiffstats
path: root/usr.bin/usbhidaction/usbhidaction.c
diff options
context:
space:
mode:
authorhselasky <hselasky@FreeBSD.org>2015-09-28 07:23:05 +0000
committerhselasky <hselasky@FreeBSD.org>2015-09-28 07:23:05 +0000
commit0f2211c30ded7871b441bfaa1647843f1b4fd0c2 (patch)
tree5f60a6fc45669979bed7dcb0fc78c2ed91ecb83d /usr.bin/usbhidaction/usbhidaction.c
parent3868cd13d745c79ffdd59413fccba469e8e7fdf5 (diff)
downloadFreeBSD-src-0f2211c30ded7871b441bfaa1647843f1b4fd0c2.zip
FreeBSD-src-0f2211c30ded7871b441bfaa1647843f1b4fd0c2.tar.gz
Store PID after becoming a daemon() and not before to ensure the
correct PID gets written to the PID file. Submitted by: Maxime Soule <btik-fbsd@scoubidou.com> PR: 203252 MFC after: 2 weeks
Diffstat (limited to 'usr.bin/usbhidaction/usbhidaction.c')
-rw-r--r--usr.bin/usbhidaction/usbhidaction.c14
1 files changed, 6 insertions, 8 deletions
diff --git a/usr.bin/usbhidaction/usbhidaction.c b/usr.bin/usbhidaction/usbhidaction.c
index 876dbca..49cf0af 100644
--- a/usr.bin/usbhidaction/usbhidaction.c
+++ b/usr.bin/usbhidaction/usbhidaction.c
@@ -166,17 +166,15 @@ main(int argc, char **argv)
if (demon) {
fp = open(pidfile, O_WRONLY|O_CREAT, S_IRUSR|S_IRGRP|S_IROTH);
- if (fp >= 0) {
- sz1 = snprintf(buf, sizeof buf, "%ld\n",
- (long)getpid());
- if (sz1 > sizeof buf)
- sz1 = sizeof buf;
- write(fp, buf, sz1);
- close(fp);
- } else
+ if (fp < 0)
err(1, "%s", pidfile);
if (daemon(0, 0) < 0)
err(1, "daemon()");
+ snprintf(buf, sizeof(buf), "%ld\n", (long)getpid());
+ sz1 = strlen(buf);
+ if (write(fp, buf, sz1) < 0)
+ err(1, "%s", pidfile);
+ close(fp);
isdemon = 1;
}
OpenPOWER on IntegriCloud