diff options
author | jilles <jilles@FreeBSD.org> | 2013-10-20 20:10:31 +0000 |
---|---|---|
committer | jilles <jilles@FreeBSD.org> | 2013-10-20 20:10:31 +0000 |
commit | 909eb57bd4467118a3b6965351fb74da22c8ecb7 (patch) | |
tree | c35fd99405fbbf51fd14024f667fa3dd655725f1 /usr.bin/pathchk | |
parent | d0ef44bd3a89c039c4c56390bf477959fadee89a (diff) | |
download | FreeBSD-src-909eb57bd4467118a3b6965351fb74da22c8ecb7.zip FreeBSD-src-909eb57bd4467118a3b6965351fb74da22c8ecb7.tar.gz |
pathchk: Ensure bytes >= 128 are considered non-portable characters.
This was not broken on architectures such as ARM where char is unsigned.
Also, remove the first non-portable character from the output. POSIX does
not require this, and printing the first byte may yield an invalid byte
sequence with UTF-8.
PR: bin/165988
Reported by: Nicolas Rachinsky
Diffstat (limited to 'usr.bin/pathchk')
-rw-r--r-- | usr.bin/pathchk/pathchk.c | 13 |
1 files changed, 6 insertions, 7 deletions
diff --git a/usr.bin/pathchk/pathchk.c b/usr.bin/pathchk/pathchk.c index 2d8fa59..3dc901b 100644 --- a/usr.bin/pathchk/pathchk.c +++ b/usr.bin/pathchk/pathchk.c @@ -98,7 +98,7 @@ check(const char *path) { struct stat sb; long complen, namemax, pathmax, svnamemax; - int badch, last; + int last; char *end, *p, *pathd; if ((pathd = strdup(path)) == NULL) @@ -142,9 +142,9 @@ check(const char *path) goto bad; } - if (pflag && (badch = portable(p)) >= 0) { + if (pflag && !portable(p)) { warnx("%s: %s: component contains non-portable " - "character `%c'", path, p, badch); + "character", path, p); goto bad; } @@ -183,8 +183,7 @@ bad: free(pathd); } /* - * Check whether a path component contains only portable characters. Return - * the first non-portable character found. + * Check whether a path component contains only portable characters. */ static int portable(const char *path) @@ -197,7 +196,7 @@ portable(const char *path) s = strspn(path, charset); if (path[s] != '\0') - return (path[s]); + return (0); - return (-1); + return (1); } |