Get rid of the sequential access feature of the lists. This was used

only in a couple of places and all of them except for one were easily
converted to use Lst_First/Lst_Succ. The one place is compatibility
mode in job.c where the it was used to advance to the next command on
each invocation of JobStart. For this case add a pointer to the node to
hold the currently executed command.

1 files changed, 1 insertions, 5 deletions

diff --git a/usr.bin/make/targ.c b/usr.bin/make/targ.c
index b10180d..5a93d7f 100644
--- a/usr.bin/make/targ.c
+++ b/usr.bin/make/targ.c
@@ -286,10 +286,7 @@ Targ_FindList(Lst *names, int flags)
 
     nodes = Lst_Init();
 
-    if (Lst_Open(names) == FAILURE) {
-	return (nodes);
-    }
-    while ((ln = Lst_Next(names)) != NULL) {
+    for (ln = Lst_First(names); ln != NULL; ln = Lst_Succ(ln)) {
 	name = Lst_Datum(ln);
 	gn = Targ_FindNode(name, flags);
 	if (gn != NULL) {
@@ -306,7 +303,6 @@ Targ_FindList(Lst *names, int flags)
 	    Error("\"%s\" -- target unknown.", name);
 	}
     }
-    Lst_Close(names);
     return (nodes);
 }