Redirect stdin from the input file, rather than passing the input file to

uuencode(1), and set a umask, so that the mode in the header is predictable.

If it varies, then the test is right to fail.

Remove the note about this test falsely failing, with that in mind.

1 files changed, 4 insertions, 6 deletions

diff --git a/tools/regression/usr.bin/uuencode/regress.sh b/tools/regression/usr.bin/uuencode/regress.sh
index 97a5986..b039768 100644
--- a/tools/regression/usr.bin/uuencode/regress.sh
+++ b/tools/regression/usr.bin/uuencode/regress.sh
@@ -9,19 +9,17 @@ cd $TESTDIR
 
 STATUS=0
 
-# Note that currently the uuencode(1) program provides no facility to
-# include the file mode explicitly based on an argument passed to it,
-# so the regress.in file must be mode 644, or the test will say that,
-# incorrectly, regression has occurred based on the header.
+# To make sure we end up with matching headers.
+umask 022
 
 for test in traditional base64; do
   echo "Running test $test"
   case "$test" in
   traditional)
-    uuencode regress.in regress.in | diff -u regress.$test.out -
+    uuencode regress.in < regress.in | diff -u regress.$test.out -
     ;;
   base64)
-    uuencode -m regress.in regress.in | diff -u regress.$test.out -
+    uuencode -m regress.in < regress.in | diff -u regress.$test.out -
     ;;
   esac
   if [ $? -eq 0 ]; then