- Don't use /tmp because it's outside ATF's prescribed sandbox

- Replace a hardcoded PATH_MAX value with sizeof(path)
- Use path like an array, not a pointer, and always try to unlink it in cleanup

MFC after: 1 week
Sponsored by: EMC / Isilon Storage Division

1 files changed, 4 insertions, 4 deletions

diff --git a/tools/regression/sockets/sendfile/sendfile.c b/tools/regression/sockets/sendfile/sendfile.c
index 73033d7..18ae9ad 100644
--- a/tools/regression/sockets/sendfile/sendfile.c
+++ b/tools/regression/sockets/sendfile/sendfile.c
@@ -452,8 +452,8 @@ run_parent(void)
 static void
 cleanup(void)
 {
-	if (*path != '\0')
-		unlink(path);
+
+	unlink(path);
 }
 
 int
@@ -461,12 +461,12 @@ main(int argc, char *argv[])
 {
 	int pagesize;
 
-	*path = '\0';
+	path[0] = '\0';
 
 	pagesize = getpagesize();
 
 	if (argc == 1) {
-		snprintf(path, PATH_MAX, "/tmp/sendfile.XXXXXXXXXXXX");
+		snprintf(path, sizeof(path), "sendfile.XXXXXXXXXXXX");
 		file_fd = mkstemp(path);
 		if (file_fd == -1)
 			FAIL_ERR("mkstemp");