Add some comments about things that have become bad as I've been

working on this code, or things that I think are layering violations.
Plus a minor whitespace cleanup in one place while I'm at it.

2 files changed, 5 insertions, 3 deletions

diff --git a/sys/dev/pcic/i82365.c b/sys/dev/pcic/i82365.c
index c51cc5e..f78f8e1 100644
--- a/sys/dev/pcic/i82365.c
+++ b/sys/dev/pcic/i82365.c
@@ -50,6 +50,8 @@
 #include <sys/kthread.h>
 #include <vm/vm.h>
 
+/* We shouldn't need to include the following, but sadly we do for now */
+/* XXX */
 #include <dev/pccard/pccardreg.h>
 #include <dev/pccard/pccardvar.h>
 
@@ -738,7 +740,7 @@ pcic_deactivate_card(struct pcic_handle *h)
 }
 
 static int 
-pcic_chip_mem_alloc(struct pcic_handle *h, bus_size_t size, 
+pcic_chip_mem_alloc(struct pcic_handle *h, bus_size_t size,
     struct pccard_mem_handle *pcmhp)
 {
 	bus_space_handle_t memh;
diff --git a/sys/dev/pcic/i82365var.h b/sys/dev/pcic/i82365var.h
index c4a5433..0286beb 100644
--- a/sys/dev/pcic/i82365var.h
+++ b/sys/dev/pcic/i82365var.h
@@ -59,9 +59,9 @@ struct pcic_handle {
 	int	flags;
 	int laststate;
 	int	memalloc;
-	struct pccard_mem_handle mem[PCIC_MEM_WINS];
+	struct pccard_mem_handle mem[PCIC_MEM_WINS];	/* XXX BAD XXX */
 	int	ioalloc;
-	struct pccard_io_handle io[PCIC_IO_WINS];
+	struct pccard_io_handle io[PCIC_IO_WINS];	/* XXX BAD XXX */
 	int	ih_irq;
 
 	int shutdown;