diff options
| author | ats <ats@FreeBSD.org> | 1994-12-01 20:20:21 +0000 |
|---|---|---|
| committer | ats <ats@FreeBSD.org> | 1994-12-01 20:20:21 +0000 |
| commit | 7a0fcd058dca864f723246bd878f131532c962b3 (patch) | |
| tree | a747443e4fbee02d6b099e98e58208d1641114bf /sys | |
| parent | c07b8f0f9b3c5995554786558fb9e6e0eab0dda8 (diff) | |
| download | FreeBSD-src-7a0fcd058dca864f723246bd878f131532c962b3.zip FreeBSD-src-7a0fcd058dca864f723246bd878f131532c962b3.tar.gz | |
The values for setrlimit in the data size and stack size case are
used as an address value. Then all comparisons should be done unsigned
and not signed. Fix it with a typecast of u_quad_t.
Error can be demonstrated with the current bash in port, do a
ulimit -s unlimited and the machine hangs. bash delivers through
an internal error a large negative value for the stacksize, the
comparison saw this smaller than MAXSSIZ and then tried to expand
the stack to this size.
Diffstat (limited to 'sys')
| -rw-r--r-- | sys/kern/kern_resource.c | 12 |
1 files changed, 6 insertions, 6 deletions
diff --git a/sys/kern/kern_resource.c b/sys/kern/kern_resource.c index 1739239..640cf94 100644 --- a/sys/kern/kern_resource.c +++ b/sys/kern/kern_resource.c @@ -36,7 +36,7 @@ * SUCH DAMAGE. * * @(#)kern_resource.c 8.5 (Berkeley) 1/21/94 - * $Id: kern_resource.c,v 1.6 1994/10/02 04:45:49 davidg Exp $ + * $Id: kern_resource.c,v 1.7 1994/10/10 01:00:46 phk Exp $ */ #include <sys/param.h> @@ -362,16 +362,16 @@ dosetrlimit(p, which, limp) switch (which) { case RLIMIT_DATA: - if (limp->rlim_cur > MAXDSIZ) + if ((u_quad_t) limp->rlim_cur > MAXDSIZ) limp->rlim_cur = MAXDSIZ; - if (limp->rlim_max > MAXDSIZ) + if ((u_quad_t) limp->rlim_max > MAXDSIZ) limp->rlim_max = MAXDSIZ; break; case RLIMIT_STACK: - if (limp->rlim_cur > MAXSSIZ) + if ((u_quad_t) limp->rlim_cur > MAXSSIZ) limp->rlim_cur = MAXSSIZ; - if (limp->rlim_max > MAXSSIZ) + if ((u_quad_t) limp->rlim_max > MAXSSIZ) limp->rlim_max = MAXSSIZ; /* * Stack is allocated to the max at exec time with only @@ -383,7 +383,7 @@ dosetrlimit(p, which, limp) vm_size_t size; vm_prot_t prot; - if (limp->rlim_cur > alimp->rlim_cur) { + if ((u_quad_t) limp->rlim_cur > alimp->rlim_cur) { prot = VM_PROT_ALL; size = limp->rlim_cur - alimp->rlim_cur; addr = USRSTACK - limp->rlim_cur; |
