summaryrefslogtreecommitdiffstats
path: root/sys
diff options
context:
space:
mode:
authorjhb <jhb@FreeBSD.org>2001-02-09 20:51:11 +0000
committerjhb <jhb@FreeBSD.org>2001-02-09 20:51:11 +0000
commit27ab00ae2a8eed9827629179c13212f15a599e39 (patch)
treefae6cadc0d8046977d4ece37fdcddd77f95cbe8b /sys
parent172bac86998f166763796b9b9f4b723694384ad1 (diff)
downloadFreeBSD-src-27ab00ae2a8eed9827629179c13212f15a599e39.zip
FreeBSD-src-27ab00ae2a8eed9827629179c13212f15a599e39.tar.gz
Revert the previous revision for two reasons:
- I can't seem to reproduce the warning I got from WITNESS anymore. - The fix was wrong. Since a uidinfo struct is a member of proc, it makes sense for the locking order to be such that you are allowed to hold proc and then grab the uidinfo lock.
Diffstat (limited to 'sys')
-rw-r--r--sys/kern/kern_exit.c2
1 files changed, 0 insertions, 2 deletions
diff --git a/sys/kern/kern_exit.c b/sys/kern/kern_exit.c
index 24a4753..71e6288 100644
--- a/sys/kern/kern_exit.c
+++ b/sys/kern/kern_exit.c
@@ -521,10 +521,8 @@ loop:
*/
PROC_LOCK(p);
if (--p->p_cred->p_refcnt == 0) {
- PROC_UNLOCK(p);
crfree(p->p_ucred);
uifree(p->p_cred->p_uidinfo);
- PROC_LOCK(p);
FREE(p->p_cred, M_SUBPROC);
p->p_cred = NULL;
}
OpenPOWER on IntegriCloud