summaryrefslogtreecommitdiffstats
path: root/sys/vm/vm_fault.c
diff options
context:
space:
mode:
authoralc <alc@FreeBSD.org>2010-05-02 17:33:46 +0000
committeralc <alc@FreeBSD.org>2010-05-02 17:33:46 +0000
commitf35e97166b133de28351ffee3f6de3407d0272b7 (patch)
tree800dba3ed92fa905f4e1acbc91746a06e2e47bc9 /sys/vm/vm_fault.c
parent1b4eb78965d8d551d4997edd6125fd401a212f5b (diff)
downloadFreeBSD-src-f35e97166b133de28351ffee3f6de3407d0272b7.zip
FreeBSD-src-f35e97166b133de28351ffee3f6de3407d0272b7.tar.gz
It makes no sense for vm_page_sleep_if_busy()'s helper, vm_page_sleep(),
to unconditionally set PG_REFERENCED on a page before sleeping. In many cases, it's perfectly ok for the page to disappear, i.e., be reclaimed by the page daemon, before the caller to vm_page_sleep() is reawakened. Instead, we now explicitly set PG_REFERENCED in those cases where having the page persist until the caller is awakened is clearly desirable. Note, however, that setting PG_REFERENCED on the page is still only a hint, and not a guarantee that the page should persist.
Diffstat (limited to 'sys/vm/vm_fault.c')
-rw-r--r--sys/vm/vm_fault.c6
1 files changed, 6 insertions, 0 deletions
diff --git a/sys/vm/vm_fault.c b/sys/vm/vm_fault.c
index d9cf63e..5ee4ab4 100644
--- a/sys/vm/vm_fault.c
+++ b/sys/vm/vm_fault.c
@@ -338,6 +338,12 @@ RetryFault:;
* to pmap it.
*/
if ((fs.m->oflags & VPO_BUSY) || fs.m->busy) {
+ /*
+ * Reference the page before unlocking and
+ * sleeping so that the page daemon is less
+ * likely to reclaim it.
+ */
+ vm_page_flag_set(fs.m, PG_REFERENCED);
vm_page_unlock_queues();
vm_page_unlock(fs.m);
VM_OBJECT_UNLOCK(fs.object);
OpenPOWER on IntegriCloud