diff options
| author | eadler <eadler@FreeBSD.org> | 2013-11-30 22:17:27 +0000 |
|---|---|---|
| committer | eadler <eadler@FreeBSD.org> | 2013-11-30 22:17:27 +0000 |
| commit | 44c01df17391f4429ee371e8039ae4fd802c2a8e (patch) | |
| tree | 050fb3b68519f6ef7d59051550fa29cdd79d6dac /sys/sys/consio.h | |
| parent | 5bcb8c5f4293579e5f8aba6f33f85246b7b70e5d (diff) | |
| download | FreeBSD-src-44c01df17391f4429ee371e8039ae4fd802c2a8e.zip FreeBSD-src-44c01df17391f4429ee371e8039ae4fd802c2a8e.tar.gz | |
Fix undefined behavior: (1 << 31) is not defined as 1 is an int and this
shifts into the sign bit. Instead use (1U << 31) which gets the
expected result.
This fix is not ideal as it assumes a 32 bit int, but does fix the issue
for most cases.
A similar change was made in OpenBSD.
Discussed with: -arch, rdivacky
Reviewed by: cperciva
Diffstat (limited to 'sys/sys/consio.h')
| -rw-r--r-- | sys/sys/consio.h | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/sys/sys/consio.h b/sys/sys/consio.h index a0022e8..33e0ebe 100644 --- a/sys/sys/consio.h +++ b/sys/sys/consio.h @@ -184,7 +184,7 @@ typedef struct mouse_info mouse_info_t; #define CONS_CURSOR_ATTRS (CONS_BLINK_CURSOR | CONS_CHAR_CURSOR | \ CONS_HIDDEN_CURSOR) #define CONS_RESET_CURSOR (1 << 30) -#define CONS_LOCAL_CURSOR (1 << 31) +#define CONS_LOCAL_CURSOR (1U << 31) #define CONS_CURSOR_FLAGS (CONS_RESET_CURSOR | CONS_LOCAL_CURSOR) struct cshape { /* shape[0]: flags, shape[1]: base, shape[2]: height */ |
