diff options
author | rwatson <rwatson@FreeBSD.org> | 2005-08-03 00:18:35 +0000 |
---|---|---|
committer | rwatson <rwatson@FreeBSD.org> | 2005-08-03 00:18:35 +0000 |
commit | 9918d13b80941400bfab87834b1e2f1eea58c7c7 (patch) | |
tree | 9a4e586ffbcd1450917ee5e388a4e1eb38254e32 /sys/pci/if_tl.c | |
parent | efa13b9da9fc80838e2c73140ae27393b3660da4 (diff) | |
download | FreeBSD-src-9918d13b80941400bfab87834b1e2f1eea58c7c7.zip FreeBSD-src-9918d13b80941400bfab87834b1e2f1eea58c7c7.tar.gz |
Modify device drivers supporting multicast addresses to lock if_addr_mtx
over iteration of their multicast address lists when synchronizing the
hardware address filter with the network stack-maintained list.
Problem reported by: Ed Maste (emaste at phaedrus dot sandvine dot ca>
MFC after: 1 week
Diffstat (limited to 'sys/pci/if_tl.c')
-rw-r--r-- | sys/pci/if_tl.c | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/sys/pci/if_tl.c b/sys/pci/if_tl.c index 3dde56a..f9d9815 100644 --- a/sys/pci/if_tl.c +++ b/sys/pci/if_tl.c @@ -960,6 +960,7 @@ tl_setmulti(sc) hashes[1] = 0xFFFFFFFF; } else { i = 1; + IF_ADDR_LOCK(ifp); TAILQ_FOREACH_REVERSE(ifma, &ifp->if_multiaddrs, ifmultihead, ifma_link) { if (ifma->ifma_addr->sa_family != AF_LINK) continue; @@ -982,6 +983,7 @@ tl_setmulti(sc) else hashes[1] |= (1 << (h - 32)); } + IF_ADDR_UNLOCK(ifp); } tl_dio_write32(sc, TL_HASH1, hashes[0]); |