diff options
| author | ru <ru@FreeBSD.org> | 2005-09-16 11:11:51 +0000 |
|---|---|---|
| committer | ru <ru@FreeBSD.org> | 2005-09-16 11:11:51 +0000 |
| commit | d2f7ab28daf6bc7f93eb290728f89c7d713ca0ce (patch) | |
| tree | eea8401041be885ba31c07333f6e0206b9d04ab0 /sys/pci/if_pcn.c | |
| parent | 02dbbd7982679f0c66e9ffa29caf799b5c1a3bde (diff) | |
| download | FreeBSD-src-d2f7ab28daf6bc7f93eb290728f89c7d713ca0ce.zip FreeBSD-src-d2f7ab28daf6bc7f93eb290728f89c7d713ca0ce.tar.gz | |
Fix "struct ifnet" leaks when attach() fails in the middle, e.g.
when mii_phy_probe() or bus_setup_intr() fails. For drivers that
call their detach() in this case, call if_free() there to cover
this case too.
Diffstat (limited to 'sys/pci/if_pcn.c')
| -rw-r--r-- | sys/pci/if_pcn.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/sys/pci/if_pcn.c b/sys/pci/if_pcn.c index 36ac644..1ec8765 100644 --- a/sys/pci/if_pcn.c +++ b/sys/pci/if_pcn.c @@ -623,7 +623,6 @@ pcn_attach(dev) if (mii_phy_probe(dev, &sc->pcn_miibus, pcn_ifmedia_upd, pcn_ifmedia_sts)) { printf("pcn%d: MII without any PHY!\n", sc->pcn_unit); - if_free(ifp); error = ENXIO; goto fail; } @@ -677,8 +676,9 @@ pcn_detach(dev) PCN_UNLOCK(sc); callout_drain(&sc->pcn_stat_callout); ether_ifdetach(ifp); - if_free(ifp); } + if (ifp) + if_free(ifp); if (sc->pcn_miibus) device_delete_child(dev, sc->pcn_miibus); bus_generic_detach(dev); |
