summaryrefslogtreecommitdiffstats
path: root/sys/opencrypto
diff options
context:
space:
mode:
authorattilio <attilio@FreeBSD.org>2013-11-25 07:38:45 +0000
committerattilio <attilio@FreeBSD.org>2013-11-25 07:38:45 +0000
commit7ee4e910ced4b311b0194fe11c664f0c6bde3bd8 (patch)
treee29b308276ced8b2028470c376a2a34193dc6c3c /sys/opencrypto
parent150d294dbc6b55504998d6f99781473171415f7f (diff)
downloadFreeBSD-src-7ee4e910ced4b311b0194fe11c664f0c6bde3bd8.zip
FreeBSD-src-7ee4e910ced4b311b0194fe11c664f0c6bde3bd8.tar.gz
- For kernel compiled only with KDTRACE_HOOKS and not any lock debugging
option, unbreak the lock tracing release semantic by embedding calls to LOCKSTAT_PROFILE_RELEASE_LOCK() direclty in the inlined version of the releasing functions for mutex, rwlock and sxlock. Failing to do so skips the lockstat_probe_func invokation for unlocking. - As part of the LOCKSTAT support is inlined in mutex operation, for kernel compiled without lock debugging options, potentially every consumer must be compiled including opt_kdtrace.h. Fix this by moving KDTRACE_HOOKS into opt_global.h and remove the dependency by opt_kdtrace.h for all files, as now only KDTRACE_FRAMES is linked there and it is only used as a compile-time stub [0]. [0] immediately shows some new bug as DTRACE-derived support for debug in sfxge is broken and it was never really tested. As it was not including correctly opt_kdtrace.h before it was never enabled so it was kept broken for a while. Fix this by using a protection stub, leaving sfxge driver authors the responsibility for fixing it appropriately [1]. Sponsored by: EMC / Isilon storage division Discussed with: rstone [0] Reported by: rstone [1] Discussed with: philip
Diffstat (limited to 'sys/opencrypto')
-rw-r--r--sys/opencrypto/crypto.c1
-rw-r--r--sys/opencrypto/deflate.c2
2 files changed, 0 insertions, 3 deletions
diff --git a/sys/opencrypto/crypto.c b/sys/opencrypto/crypto.c
index 53c11e6..889e855 100644
--- a/sys/opencrypto/crypto.c
+++ b/sys/opencrypto/crypto.c
@@ -57,7 +57,6 @@ __FBSDID("$FreeBSD$");
#define CRYPTO_TIMING /* enable timing support */
#include "opt_ddb.h"
-#include "opt_kdtrace.h"
#include <sys/param.h>
#include <sys/systm.h>
diff --git a/sys/opencrypto/deflate.c b/sys/opencrypto/deflate.c
index deaf052..cf3a5b1 100644
--- a/sys/opencrypto/deflate.c
+++ b/sys/opencrypto/deflate.c
@@ -35,8 +35,6 @@
#include <sys/cdefs.h>
__FBSDID("$FreeBSD$");
-#include "opt_kdtrace.h"
-
#include <sys/types.h>
#include <sys/param.h>
#include <sys/malloc.h>
OpenPOWER on IntegriCloud