diff options
| author | bz <bz@FreeBSD.org> | 2006-01-21 10:44:34 +0000 |
|---|---|---|
| committer | bz <bz@FreeBSD.org> | 2006-01-21 10:44:34 +0000 |
| commit | 6d9ab80fce79d4befb78b6264b0cfe789cdeac58 (patch) | |
| tree | 6592dbe525d1fa703ba65343df6cd7f697d18423 /sys/netipsec/keysock.h | |
| parent | 0da5dd341ca939cb09f09ca6e0b9d4b978a60690 (diff) | |
| download | FreeBSD-src-6d9ab80fce79d4befb78b6264b0cfe789cdeac58.zip FreeBSD-src-6d9ab80fce79d4befb78b6264b0cfe789cdeac58.tar.gz | |
Fix stack corruptions on amd64.
Vararg functions have a different calling convention than regular
functions on amd64. Casting a varag function to a regular one to
match the function pointer declaration will hide the varargs from
the caller and we will end up with an incorrectly setup stack.
Entirely remove the varargs from these functions and change the
functions to match the declaration of the function pointers.
Remove the now unnecessary casts.
Lots of explanations and help from: peter
Reviewed by: peter
PR: amd64/89261
MFC after: 6 days
Diffstat (limited to 'sys/netipsec/keysock.h')
| -rw-r--r-- | sys/netipsec/keysock.h | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/sys/netipsec/keysock.h b/sys/netipsec/keysock.h index d8d27d2..a331b5e 100644 --- a/sys/netipsec/keysock.h +++ b/sys/netipsec/keysock.h @@ -71,7 +71,7 @@ struct keycb { extern struct pfkeystat pfkeystat; -extern int key_output __P((struct mbuf *, ...)); +extern int key_output(struct mbuf *m, struct socket *so); extern int key_usrreq __P((struct socket *, int, struct mbuf *, struct mbuf *, struct mbuf *)); |
