diff options
author | hiren <hiren@FreeBSD.org> | 2015-07-22 15:05:45 +0000 |
---|---|---|
committer | hiren <hiren@FreeBSD.org> | 2015-07-22 15:05:45 +0000 |
commit | 141df3ac0974885e597dc428df134a87aa581211 (patch) | |
tree | bd8b2f0e8ead85f6ace49994d4024d0bd1717344 /sys/netinet | |
parent | 457165363e08c575f189297c574b0dcd6753945d (diff) | |
download | FreeBSD-src-141df3ac0974885e597dc428df134a87aa581211.zip FreeBSD-src-141df3ac0974885e597dc428df134a87aa581211.tar.gz |
MFC r284941:
Avoid a situation where we do not set persist timer after a zero window
condition.
If you send a 0-length packet, but there is data is the socket buffer, and
neither the rexmt or persist timer is already set, then activate the persist
timer.
PR: 192599
Approved by: re (delphij)
Diffstat (limited to 'sys/netinet')
-rw-r--r-- | sys/netinet/tcp_output.c | 24 |
1 files changed, 24 insertions, 0 deletions
diff --git a/sys/netinet/tcp_output.c b/sys/netinet/tcp_output.c index f7265dc..ba0ec40 100644 --- a/sys/netinet/tcp_output.c +++ b/sys/netinet/tcp_output.c @@ -1397,6 +1397,30 @@ timer: tp->t_rxtshift = 0; } tcp_timer_activate(tp, TT_REXMT, tp->t_rxtcur); + } else if (len == 0 && so->so_snd.sb_cc && + !tcp_timer_active(tp, TT_REXMT) && + !tcp_timer_active(tp, TT_PERSIST)) { + /* + * Avoid a situation where we do not set persist timer + * after a zero window condition. For example: + * 1) A -> B: packet with enough data to fill the window + * 2) B -> A: ACK for #1 + new data (0 window + * advertisement) + * 3) A -> B: ACK for #2, 0 len packet + * + * In this case, A will not activate the persist timer, + * because it chose to send a packet. Unless tcp_output + * is called for some other reason (delayed ack timer, + * another input packet from B, socket syscall), A will + * not send zero window probes. + * + * So, if you send a 0-length packet, but there is data + * in the socket buffer, and neither the rexmt or + * persist timer is already set, then activate the + * persist timer. + */ + tp->t_rxtshift = 0; + tcp_setpersist(tp); } } else { /* |