diff options
| author | andre <andre@FreeBSD.org> | 2010-08-18 17:39:47 +0000 |
|---|---|---|
| committer | andre <andre@FreeBSD.org> | 2010-08-18 17:39:47 +0000 |
| commit | 82e4bb536ac304054c6d49d74651f89b7846106d (patch) | |
| tree | 1891fe16b73f945b8252ca062e79b5342b435c56 /sys/netinet/tcp_input.c | |
| parent | 95a3f24d1676e8b4016f4dbc0ee2eb63af12ac2f (diff) | |
| download | FreeBSD-src-82e4bb536ac304054c6d49d74651f89b7846106d.zip FreeBSD-src-82e4bb536ac304054c6d49d74651f89b7846106d.tar.gz | |
Untangle the net.inet.tcp.log_in_vain and net.inet.tcp.log_debug
sysctl's and remove any side effects.
Both sysctl's share the same backend infrastructure and due to the
way it was implemented enabling net.inet.tcp.log_in_vain would also
cause log_debug output to be generated. This was surprising and
eventually annoying to the user.
The log output backend is kept the same but a little shim is inserted
to properly separate log_in_vain and log_debug and to remove any side
effects.
PR: kern/137317
MFC after: 1 week
Diffstat (limited to 'sys/netinet/tcp_input.c')
| -rw-r--r-- | sys/netinet/tcp_input.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/sys/netinet/tcp_input.c b/sys/netinet/tcp_input.c index cbba9cd..05671ce 100644 --- a/sys/netinet/tcp_input.c +++ b/sys/netinet/tcp_input.c @@ -571,7 +571,7 @@ findpcb: */ if ((tcp_log_in_vain == 1 && (thflags & TH_SYN)) || tcp_log_in_vain == 2) { - if ((s = tcp_log_addrs(NULL, th, (void *)ip, ip6))) + if ((s = tcp_log_vain(NULL, th, (void *)ip, ip6))) log(LOG_INFO, "%s; %s: Connection attempt " "to closed port\n", s, __func__); } |
