Fix up some sloppy coding practices:

- Delete redundant declarations.
- Add -Wredundant-declarations to Makefile.i386 so they don't come back.
- Delete sloppy COMMON-style declarations of uninitialized data in
  header files.
- Add a few prototypes.
- Clean up warnings resulting from the above.

NB: ioconf.c will still generate a redundant-declaration warning, which
is unavoidable unless somebody volunteers to make `config' smarter.

5 files changed, 11 insertions, 11 deletions

diff --git a/sys/net/if.c b/sys/net/if.c
index 76718e2..02741d0 100644
--- a/sys/net/if.c
+++ b/sys/net/if.c
@@ -31,7 +31,7 @@
  * SUCH DAMAGE.
  *
  *	@(#)if.c	8.3 (Berkeley) 1/4/94
- * $Id: if.c,v 1.4 1994/08/08 10:58:30 davidg Exp $
+ * $Id: if.c,v 1.5 1994/08/08 11:43:44 davidg Exp $
  */
 
 #include <sys/param.h>
@@ -49,7 +49,6 @@
 #include <net/if_types.h>
 
 int	ifqmaxlen = IFQ_MAXLEN;
-void	if_slowtimo __P((void *arg));
 
 /*
  * Network interface utility routines.
@@ -97,13 +96,13 @@ if_attach(ifp)
 	struct ifnet *ifp;
 {
 	unsigned socksize, ifasize;
-	int namelen, unitlen, masklen, ether_output();
+	int namelen, unitlen, masklen;
 	char workbuf[12], *unitname;
 	register struct ifnet **p = &ifnet;
 	register struct sockaddr_dl *sdl;
 	register struct ifaddr *ifa;
 	static int if_indexlim = 8;
-	extern void link_rtrequest();
+
 
 	while (*p)
 		p = &((*p)->if_next);
diff --git a/sys/net/if.h b/sys/net/if.h
index 107d7e7..3b1e6d8 100644
--- a/sys/net/if.h
+++ b/sys/net/if.h
@@ -31,7 +31,7 @@
  * SUCH DAMAGE.
  *
  *	@(#)if.h	8.1 (Berkeley) 6/10/93
- * $Id: if.h,v 1.3 1994/08/02 07:46:07 davidg Exp $
+ * $Id: if.h,v 1.4 1994/08/08 10:49:19 davidg Exp $
  */
 
 /*
@@ -343,7 +343,7 @@ void	if_up __P((struct ifnet *));
 void	ifubareset __P((int));
 #endif
 int	ifconf __P((int, caddr_t));
-void	ifinit __P((void));
+/*void	ifinit __P((void));*/ /* declared in systm.h for main() */
 int	ifioctl __P((struct socket *, int, caddr_t, struct proc *));
 int	ifpromisc __P((struct ifnet *, int));
 struct	ifnet *ifunit __P((char *));
diff --git a/sys/net/if_sl.c b/sys/net/if_sl.c
index 7865c3c..df83d3e 100644
--- a/sys/net/if_sl.c
+++ b/sys/net/if_sl.c
@@ -31,7 +31,7 @@
  * SUCH DAMAGE.
  *
  *	@(#)if_sl.c	8.6 (Berkeley) 2/1/94
- * $Id$
+ * $Id: if_sl.c,v 1.3 1994/08/02 07:46:20 davidg Exp $
  */
 
 /*
@@ -71,6 +71,7 @@
 #include "bpfilter.h"
 
 #include <sys/param.h>
+#include <sys/systm.h>
 #include <sys/proc.h>
 #include <sys/mbuf.h>
 #include <sys/buf.h>
@@ -177,8 +178,6 @@ struct sl_softc sl_softc[NSL];
 #define TRANS_FRAME_END	 	0xdc		/* transposed frame end */
 #define TRANS_FRAME_ESCAPE 	0xdd		/* transposed frame esc */
 
-extern struct timeval time;
-
 static int slinit __P((struct sl_softc *));
 static struct mbuf *sl_btom __P((struct sl_softc *, int));
 
diff --git a/sys/net/raw_usrreq.c b/sys/net/raw_usrreq.c
index 41c72fa..f52ea56 100644
--- a/sys/net/raw_usrreq.c
+++ b/sys/net/raw_usrreq.c
@@ -31,10 +31,11 @@
  * SUCH DAMAGE.
  *
  *	@(#)raw_usrreq.c	8.1 (Berkeley) 6/10/93
- * $Id$
+ * $Id: raw_usrreq.c,v 1.2 1994/08/02 07:46:38 davidg Exp $
  */
 
 #include <sys/param.h>
+#include <sys/systm.h>
 #include <sys/mbuf.h>
 #include <sys/domain.h>
 #include <sys/protosw.h>
diff --git a/sys/net/slcompress.c b/sys/net/slcompress.c
index 4439ce4..bebeeab 100644
--- a/sys/net/slcompress.c
+++ b/sys/net/slcompress.c
@@ -31,7 +31,7 @@
  * SUCH DAMAGE.
  *
  *	@(#)slcompress.c	8.2 (Berkeley) 4/16/94
- * $Id$
+ * $Id: slcompress.c,v 1.2 1994/08/02 07:46:46 davidg Exp $
  */
 
 /*
@@ -44,6 +44,7 @@
  */
 
 #include <sys/param.h>
+#include <sys/systm.h>
 #include <sys/mbuf.h>
 
 #include <netinet/in.h>