diff options
| author | attilio <attilio@FreeBSD.org> | 2009-08-17 16:17:21 +0000 |
|---|---|---|
| committer | attilio <attilio@FreeBSD.org> | 2009-08-17 16:17:21 +0000 |
| commit | e75d30c87f88cc8122139e051639281f766a20ed (patch) | |
| tree | c287450b66e6c82a706049a48c5fcff40a6bc3b5 /sys/kern/kern_mutex.c | |
| parent | 61d6cdbea1c290b707b3e593b66d13469c3be675 (diff) | |
| download | FreeBSD-src-e75d30c87f88cc8122139e051639281f766a20ed.zip FreeBSD-src-e75d30c87f88cc8122139e051639281f766a20ed.tar.gz | |
* Change the scope of the ASSERT_ATOMIC_LOAD() from a generic check to
a pointer-fetching specific operation check. Consequently, rename the
operation ASSERT_ATOMIC_LOAD_PTR().
* Fix the implementation of ASSERT_ATOMIC_LOAD_PTR() by checking
directly alignment on the word boundry, for all the given specific
architectures. That's a bit too strict for some common case, but it
assures safety.
* Add a comment explaining the scope of the macro
* Add a new stub in the lockmgr specific implementation
Tested by: marcel (initial version), marius
Reviewed by: rwatson, jhb (comment specific review)
Approved by: re (kib)
Diffstat (limited to 'sys/kern/kern_mutex.c')
| -rw-r--r-- | sys/kern/kern_mutex.c | 5 |
1 files changed, 3 insertions, 2 deletions
diff --git a/sys/kern/kern_mutex.c b/sys/kern/kern_mutex.c index f625098..85ca646 100644 --- a/sys/kern/kern_mutex.c +++ b/sys/kern/kern_mutex.c @@ -783,8 +783,9 @@ mtx_init(struct mtx *m, const char *name, const char *type, int opts) MPASS((opts & ~(MTX_SPIN | MTX_QUIET | MTX_RECURSE | MTX_NOWITNESS | MTX_DUPOK | MTX_NOPROFILE)) == 0); - ASSERT_ATOMIC_LOAD(m->mtx_lock, ("%s: mtx_lock not aligned for %s: %p", - __func__, name, &m->mtx_lock)); + ASSERT_ATOMIC_LOAD_PTR(m->mtx_lock, + ("%s: mtx_lock not aligned for %s: %p", __func__, name, + &m->mtx_lock)); #ifdef MUTEX_DEBUG /* Diagnostic and error correction */ |
