diff options
| author | mjg <mjg@FreeBSD.org> | 2014-10-20 22:52:15 +0000 |
|---|---|---|
| committer | mjg <mjg@FreeBSD.org> | 2014-10-20 22:52:15 +0000 |
| commit | a21afe61383c6765fbef6b0f4c582d4adb3ac5e4 (patch) | |
| tree | e836eab4226c3b4192915612699c329977817465 /sys/kern/kern_exec.c | |
| parent | f1a57b3826491cc58fd220f317ce0e5bbaec9edf (diff) | |
| download | FreeBSD-src-a21afe61383c6765fbef6b0f4c582d4adb3ac5e4.zip FreeBSD-src-a21afe61383c6765fbef6b0f4c582d4adb3ac5e4.tar.gz | |
Plug unnecessary binvp NULL initialization and test.
Reported by: Coverity
CID: 1018889
Diffstat (limited to 'sys/kern/kern_exec.c')
| -rw-r--r-- | sys/kern/kern_exec.c | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/sys/kern/kern_exec.c b/sys/kern/kern_exec.c index fd1e214..f2bbdaa 100644 --- a/sys/kern/kern_exec.c +++ b/sys/kern/kern_exec.c @@ -348,7 +348,7 @@ do_execve(td, args, mac_p) struct vnode *tracevp = NULL; struct ucred *tracecred = NULL; #endif - struct vnode *textvp = NULL, *binvp = NULL; + struct vnode *textvp = NULL, *binvp; cap_rights_t rights; int credential_changing; int textset; @@ -422,7 +422,7 @@ interpret: if (error) goto exec_fail; - binvp = nd.ni_vp; + binvp = nd.ni_vp; imgp->vp = binvp; } else { AUDIT_ARG_FD(args->fd); @@ -839,7 +839,7 @@ done1: */ if (textvp != NULL) vrele(textvp); - if (binvp && error != 0) + if (error != 0) vrele(binvp); #ifdef KTRACE if (tracevp != NULL) |
