summaryrefslogtreecommitdiffstats
path: root/sys/kern/kern_exec.c
diff options
context:
space:
mode:
authormjg <mjg@FreeBSD.org>2014-10-31 09:56:00 +0000
committermjg <mjg@FreeBSD.org>2014-10-31 09:56:00 +0000
commit6b53d30f115a091f8d1e52ee34c6cb4e5a5a5448 (patch)
tree7df24ba1efb9544f08a78084e5bc04fd6eddab1d /sys/kern/kern_exec.c
parent96f82a0d0c95534578790ab0d906ebe7730ed5bc (diff)
downloadFreeBSD-src-6b53d30f115a091f8d1e52ee34c6cb4e5a5a5448.zip
FreeBSD-src-6b53d30f115a091f8d1e52ee34c6cb4e5a5a5448.tar.gz
filedesc: fix missed comments about fdsetugidsafety
While here just note that both fdsetugidsafety and fdcheckstd take sleepable locks.
Diffstat (limited to 'sys/kern/kern_exec.c')
-rw-r--r--sys/kern/kern_exec.c6
1 files changed, 2 insertions, 4 deletions
diff --git a/sys/kern/kern_exec.c b/sys/kern/kern_exec.c
index 45d4c6f..7ae7d4e 100644
--- a/sys/kern/kern_exec.c
+++ b/sys/kern/kern_exec.c
@@ -688,10 +688,8 @@ interpret:
* Close any file descriptors 0..2 that reference procfs,
* then make sure file descriptors 0..2 are in use.
*
- * setugidsafety() may call closef() and then pfind()
- * which may grab the process lock.
- * fdcheckstd() may call falloc() which may block to
- * allocate memory, so temporarily drop the process lock.
+ * Both fdsetugidsafety() and fdcheckstd() may call functions
+ * taking sleepable locks, so temporarily drop our locks.
*/
PROC_UNLOCK(p);
VOP_UNLOCK(imgp->vp, 0);
OpenPOWER on IntegriCloud