summaryrefslogtreecommitdiffstats
path: root/sys/i386/ibcs2
diff options
context:
space:
mode:
authorjhb <jhb@FreeBSD.org>2006-07-11 20:52:08 +0000
committerjhb <jhb@FreeBSD.org>2006-07-11 20:52:08 +0000
commit9569e81b84ed0c26711793ca8d937e6f7e27e6b3 (patch)
tree94d4dd9191eef2b3777b8242fb56fc1d507c2645 /sys/i386/ibcs2
parent05bff8fb74812f6551cd13f62046027a7d91e606 (diff)
downloadFreeBSD-src-9569e81b84ed0c26711793ca8d937e6f7e27e6b3.zip
FreeBSD-src-9569e81b84ed0c26711793ca8d937e6f7e27e6b3.tar.gz
- Add conditional VFS Giant locking to getdents_common() (linux ABIs),
ibcs2_getdents(), ibcs2_read(), ogetdirentries(), svr4_sys_getdents(), and svr4_sys_getdents64() similar to that in getdirentries(). - Mark ibcs2_getdents(), ibcs2_read(), linux_getdents(), linux_getdents64(), linux_readdir(), ogetdirentries(), svr4_sys_getdents(), and svr4_sys_getdents64() MPSAFE.
Diffstat (limited to 'sys/i386/ibcs2')
-rw-r--r--sys/i386/ibcs2/ibcs2_misc.c10
-rw-r--r--sys/i386/ibcs2/syscalls.master4
2 files changed, 10 insertions, 4 deletions
diff --git a/sys/i386/ibcs2/ibcs2_misc.c b/sys/i386/ibcs2/ibcs2_misc.c
index c875075..042505f 100644
--- a/sys/i386/ibcs2/ibcs2_misc.c
+++ b/sys/i386/ibcs2/ibcs2_misc.c
@@ -329,7 +329,7 @@ ibcs2_getdents(td, uap)
struct iovec aiov;
struct ibcs2_dirent idb;
off_t off; /* true file offset */
- int buflen, error, eofflag;
+ int buflen, error, eofflag, vfslocked;
u_long *cookies = NULL, *cookiep;
int ncookies;
#define BSD_DIRENT(cp) ((struct dirent *)(cp))
@@ -342,7 +342,9 @@ ibcs2_getdents(td, uap)
return (EBADF);
}
vp = fp->f_vnode;
+ vfslocked = VFS_LOCK_GIANT(vp->v_mount);
if (vp->v_type != VDIR) { /* XXX vnode readdir op should do this */
+ VFS_UNLOCK_GIANT(vfslocked);
fdrop(fp, td);
return (EINVAL);
}
@@ -459,6 +461,7 @@ eof:
td->td_retval[0] = uap->nbytes - resid;
out:
VOP_UNLOCK(vp, 0, td);
+ VFS_UNLOCK_GIANT(vfslocked);
fdrop(fp, td);
if (cookies)
free(cookies, M_TEMP);
@@ -484,7 +487,7 @@ ibcs2_read(td, uap)
char name[14];
} idb;
off_t off; /* true file offset */
- int buflen, error, eofflag, size;
+ int buflen, error, eofflag, size, vfslocked;
u_long *cookies = NULL, *cookiep;
int ncookies;
@@ -499,7 +502,9 @@ ibcs2_read(td, uap)
return (EBADF);
}
vp = fp->f_vnode;
+ vfslocked = VFS_LOCK_GIANT(vp->v_mount);
if (vp->v_type != VDIR) {
+ VFS_UNLOCK_GIANT(vfslocked);
fdrop(fp, td);
return read(td, (struct read_args *)uap);
}
@@ -622,6 +627,7 @@ eof:
td->td_retval[0] = uap->nbytes - resid;
out:
VOP_UNLOCK(vp, 0, td);
+ VFS_UNLOCK_GIANT(vfslocked);
fdrop(fp, td);
if (cookies)
free(cookies, M_TEMP);
diff --git a/sys/i386/ibcs2/syscalls.master b/sys/i386/ibcs2/syscalls.master
index ed79cb5..fe4302e6 100644
--- a/sys/i386/ibcs2/syscalls.master
+++ b/sys/i386/ibcs2/syscalls.master
@@ -39,7 +39,7 @@
1 AUE_EXIT MNOPROTO { void sys_exit(int rval); } exit \
sys_exit_args void
2 AUE_FORK MNOPROTO { int fork(void); }
-3 AUE_NULL STD { int ibcs2_read(int fd, char *buf, \
+3 AUE_NULL MSTD { int ibcs2_read(int fd, char *buf, \
u_int nbytes); }
4 AUE_NULL MNOPROTO { int write(int fd, char *buf, \
u_int nbytes); }
@@ -146,7 +146,7 @@
78 AUE_NULL UNIMPL rfs_rfsys
79 AUE_RMDIR MSTD { int ibcs2_rmdir(char *path); }
80 AUE_MKDIR MSTD { int ibcs2_mkdir(char *path, int mode); }
-81 AUE_GETDIRENTRIES STD { int ibcs2_getdents(int fd, char *buf, \
+81 AUE_GETDIRENTRIES MSTD { int ibcs2_getdents(int fd, char *buf, \
int nbytes); }
82 AUE_NULL UNIMPL nosys
83 AUE_NULL UNIMPL nosys
OpenPOWER on IntegriCloud