diff options
author | bde <bde@FreeBSD.org> | 1995-03-28 07:58:53 +0000 |
---|---|---|
committer | bde <bde@FreeBSD.org> | 1995-03-28 07:58:53 +0000 |
commit | 4f64fe43e7186660d972f9eae509424f1addaa8a (patch) | |
tree | e153346dd5a88815c9c3e7f6748d7766c40a6b0d /sys/gnu | |
parent | 6ad7636d4a24ed5873a051888c579f5ef47677c4 (diff) | |
download | FreeBSD-src-4f64fe43e7186660d972f9eae509424f1addaa8a.zip FreeBSD-src-4f64fe43e7186660d972f9eae509424f1addaa8a.tar.gz |
Add and move declarations to fix all of the warnings from `gcc -Wimplicit'
(except in netccitt, netiso and netns) that I didn't notice when I fixed
"all" such warnings before.
Diffstat (limited to 'sys/gnu')
-rw-r--r-- | sys/gnu/ext2fs/ext2_bmap.c | 5 | ||||
-rw-r--r-- | sys/gnu/fs/ext2fs/ext2_bmap.c | 5 | ||||
-rw-r--r-- | sys/gnu/i386/isa/nic3008.c | 15 | ||||
-rw-r--r-- | sys/gnu/i386/isa/nic3009.c | 14 | ||||
-rw-r--r-- | sys/gnu/isdn/iispy.c | 9 | ||||
-rw-r--r-- | sys/gnu/isdn/iitel.c | 9 | ||||
-rw-r--r-- | sys/gnu/isdn/iitty.c | 18 | ||||
-rw-r--r-- | sys/gnu/isdn/isdn.c | 10 | ||||
-rw-r--r-- | sys/gnu/isdn/isdn_ioctl.h | 41 |
9 files changed, 97 insertions, 29 deletions
diff --git a/sys/gnu/ext2fs/ext2_bmap.c b/sys/gnu/ext2fs/ext2_bmap.c index bb875f5..1bc8455 100644 --- a/sys/gnu/ext2fs/ext2_bmap.c +++ b/sys/gnu/ext2fs/ext2_bmap.c @@ -36,10 +36,11 @@ * SUCH DAMAGE. * * @(#)ufs_bmap.c 8.6 (Berkeley) 1/21/94 - * $Id: ufs_bmap.c,v 1.5 1995/01/09 16:05:25 davidg Exp $ + * $Id: ufs_bmap.c,v 1.6 1995/03/04 03:24:45 davidg Exp $ */ #include <sys/param.h> +#include <sys/systm.h> #include <sys/buf.h> #include <sys/proc.h> #include <sys/vnode.h> @@ -53,8 +54,6 @@ #include <ufs/ufs/ufsmount.h> #include <ufs/ufs/ufs_extern.h> -int ufs_bmaparray __P((struct vnode *, daddr_t, daddr_t *, struct indir *, int *, int *)); - /* * Bmap converts a the logical block number of a file to its physical block * number on the disk. The conversion is done by using the logical block diff --git a/sys/gnu/fs/ext2fs/ext2_bmap.c b/sys/gnu/fs/ext2fs/ext2_bmap.c index bb875f5..1bc8455 100644 --- a/sys/gnu/fs/ext2fs/ext2_bmap.c +++ b/sys/gnu/fs/ext2fs/ext2_bmap.c @@ -36,10 +36,11 @@ * SUCH DAMAGE. * * @(#)ufs_bmap.c 8.6 (Berkeley) 1/21/94 - * $Id: ufs_bmap.c,v 1.5 1995/01/09 16:05:25 davidg Exp $ + * $Id: ufs_bmap.c,v 1.6 1995/03/04 03:24:45 davidg Exp $ */ #include <sys/param.h> +#include <sys/systm.h> #include <sys/buf.h> #include <sys/proc.h> #include <sys/vnode.h> @@ -53,8 +54,6 @@ #include <ufs/ufs/ufsmount.h> #include <ufs/ufs/ufs_extern.h> -int ufs_bmaparray __P((struct vnode *, daddr_t, daddr_t *, struct indir *, int *, int *)); - /* * Bmap converts a the logical block number of a file to its physical block * number on the disk. The conversion is done by using the logical block diff --git a/sys/gnu/i386/isa/nic3008.c b/sys/gnu/i386/isa/nic3008.c index bb9f57e..084ff3f 100644 --- a/sys/gnu/i386/isa/nic3008.c +++ b/sys/gnu/i386/isa/nic3008.c @@ -1,6 +1,6 @@ -static char nic38_id[] = "@(#)$Id: nic3008.c,v 1.2 1995/02/15 11:59:40 jkh Exp $"; +static char nic38_id[] = "@(#)$Id: nic3008.c,v 1.3 1995/03/19 14:28:35 davidg Exp $"; /******************************************************************************* - * II - Version 0.1 $Revision: 1.2 $ $State: Exp $ + * II - Version 0.1 $Revision: 1.3 $ $State: Exp $ * * Copyright 1994 Dietmar Friede ******************************************************************************* @@ -10,6 +10,9 @@ static char nic38_id[] = "@(#)$Id: nic3008.c,v 1.2 1995/02/15 11:59:40 jkh E * ******************************************************************************* * $Log: nic3008.c,v $ + * Revision 1.3 1995/03/19 14:28:35 davidg + * Removed redundant newlines that were in some panic strings. + * * Revision 1.2 1995/02/15 11:59:40 jkh * Fix a few more nits. Should compile better now! :_) * @@ -40,6 +43,7 @@ static char nic38_id[] = "@(#)$Id: nic3008.c,v 1.2 1995/02/15 11:59:40 jkh E #include "ioctl.h" #include "kernel.h" #include "systm.h" +#include <sys/proc.h> #include "i386/isa/isa_device.h" #include "gnu/i386/isa/nic3008.h" @@ -817,8 +821,11 @@ b_intr(int mb, int c, struct nic_softc * sc) { chan->state = IDLE; ctrl->o_len = 0; - timeout(isdn_start_out, (void *)chan->ctrl, - hz/5); + /* + * XXX the chan->ctrl arg is very bogus. + * Don't just use a cast to "fix" it. + */ + timeout(isdn_start_out, chan->ctrl, hz / 5); break; } break; diff --git a/sys/gnu/i386/isa/nic3009.c b/sys/gnu/i386/isa/nic3009.c index c4e7a13..af84c50 100644 --- a/sys/gnu/i386/isa/nic3009.c +++ b/sys/gnu/i386/isa/nic3009.c @@ -1,6 +1,6 @@ -static char nic39_id[] = "@(#)$Id: nic3009.c,v 1.3 1995/02/15 11:59:41 jkh Exp $"; +static char nic39_id[] = "@(#)$Id: nic3009.c,v 1.4 1995/02/16 08:06:21 jkh Exp $"; /******************************************************************************* - * II - Version 0.1 $Revision: 1.3 $ $State: Exp $ + * II - Version 0.1 $Revision: 1.4 $ $State: Exp $ * * Copyright 1994 Dietmar Friede ******************************************************************************* @@ -10,6 +10,9 @@ static char nic39_id[] = "@(#)$Id: nic3009.c,v 1.3 1995/02/15 11:59:41 jkh E * ******************************************************************************* * $Log: nic3009.c,v $ + * Revision 1.4 1995/02/16 08:06:21 jkh + * Fix a few bogons introduced when config lost the 3 char limitation. + * * Revision 1.3 1995/02/15 11:59:41 jkh * Fix a few more nits. Should compile better now! :_) * @@ -43,6 +46,7 @@ static char nic39_id[] = "@(#)$Id: nic3009.c,v 1.3 1995/02/15 11:59:41 jkh E #include "ioctl.h" #include "kernel.h" #include "systm.h" +#include "proc.h" #include "i386/isa/isa_device.h" #include "gnu/i386/isa/nic3009.h" @@ -1116,7 +1120,11 @@ up_intr(unsigned unit, struct nnic_softc * sc) { chan->state = IDLE; ctrl->o_len = 0; - timeout(isdn_start_out,(void *)chan->ctrl,hz/5); + /* + * XXX the chan->ctrl arg is very bogus. + * Don't just use a cast to "fix" it. + */ + timeout(isdn_start_out, chan->ctrl, hz / 5); } break; diff --git a/sys/gnu/isdn/iispy.c b/sys/gnu/isdn/iispy.c index a88159b..7d17076 100644 --- a/sys/gnu/isdn/iispy.c +++ b/sys/gnu/isdn/iispy.c @@ -1,6 +1,6 @@ -static char _ispyid[] = "@(#)$Id: iispy.c,v 1.1 1995/02/14 15:00:29 jkh Exp $"; +static char _ispyid[] = "@(#)$Id: iispy.c,v 1.2 1995/02/15 06:28:27 jkh Exp $"; /******************************************************************************* - * II - Version 0.1 $Revision: 1.1 $ $State: Exp $ + * II - Version 0.1 $Revision: 1.2 $ $State: Exp $ * * Copyright 1994 Dietmar Friede ******************************************************************************* @@ -10,6 +10,9 @@ static char _ispyid[] = "@(#)$Id: iispy.c,v 1.1 1995/02/14 15:00:29 jkh Exp * ******************************************************************************* * $Log: iispy.c,v $ + * Revision 1.2 1995/02/15 06:28:27 jkh + * Fix up include paths, nuke some warnings. + * * Revision 1.1 1995/02/14 15:00:29 jkh * An ISDN driver that supports the EDSS1 and the 1TR6 ISDN interfaces. * EDSS1 is the "Euro-ISDN", 1TR6 is the soon obsolete german ISDN Interface. @@ -38,8 +41,6 @@ static char _ispyid[] = "@(#)$Id: iispy.c,v 1.1 1995/02/14 15:00:29 jkh Exp #include "gnu/isdn/isdn_ioctl.h" -int ispyattach(); - int nispy = NISPY; int ispy_applnr; static int next_if =0; diff --git a/sys/gnu/isdn/iitel.c b/sys/gnu/isdn/iitel.c index 1d801e1..f751963 100644 --- a/sys/gnu/isdn/iitel.c +++ b/sys/gnu/isdn/iitel.c @@ -1,6 +1,6 @@ -static char _itelid[] = "@(#)$Id: iitel.c,v 1.1 1995/02/14 15:00:30 jkh Exp $"; +static char _itelid[] = "@(#)$Id: iitel.c,v 1.2 1995/02/15 06:28:27 jkh Exp $"; /******************************************************************************* - * II - Version 0.1 $Revision: 1.1 $ $State: Exp $ + * II - Version 0.1 $Revision: 1.2 $ $State: Exp $ * * Copyright 1994 Dietmar Friede ******************************************************************************* @@ -10,6 +10,9 @@ static char _itelid[] = "@(#)$Id: iitel.c,v 1.1 1995/02/14 15:00:30 jkh Exp * ******************************************************************************* * $Log: iitel.c,v $ + * Revision 1.2 1995/02/15 06:28:27 jkh + * Fix up include paths, nuke some warnings. + * * Revision 1.1 1995/02/14 15:00:30 jkh * An ISDN driver that supports the EDSS1 and the 1TR6 ISDN interfaces. * EDSS1 is the "Euro-ISDN", 1TR6 is the soon obsolete german ISDN Interface. @@ -38,8 +41,6 @@ static char _itelid[] = "@(#)$Id: iitel.c,v 1.1 1995/02/14 15:00:30 jkh Exp #include "gnu/isdn/isdn_ioctl.h" -int itelattach(); - int nitel = NITEL; static int applnr[NITEL]; static int next_if =0; diff --git a/sys/gnu/isdn/iitty.c b/sys/gnu/isdn/iitty.c index a58793b..03d5f72 100644 --- a/sys/gnu/isdn/iitty.c +++ b/sys/gnu/isdn/iitty.c @@ -1,6 +1,6 @@ -static char _ittyid[] = "@(#)$Id: iitty.c,v 1.3 1995/02/25 20:08:52 pst Exp $"; +static char _ittyid[] = "@(#)$Id: iitty.c,v 1.4 1995/02/28 00:20:30 pst Exp $"; /******************************************************************************* - * II - Version 0.1 $Revision: 1.3 $ $State: Exp $ + * II - Version 0.1 $Revision: 1.4 $ $State: Exp $ * * Copyright 1994 Dietmar Friede ******************************************************************************* @@ -10,6 +10,18 @@ static char _ittyid[] = "@(#)$Id: iitty.c,v 1.3 1995/02/25 20:08:52 pst Exp * ******************************************************************************* * $Log: iitty.c,v $ + * Revision 1.4 1995/02/28 00:20:30 pst + * Incorporate bde's code-review comments. + * + * (a) bring back ttselect, now that we have xxxdevtotty() it isn't dangerous. + * (b) remove all of the wrappers that have been replaced by ttselect + * (c) fix formatting in syscons.c and definition in syscons.h + * (d) add cxdevtotty + * + * NOT DONE: + * (e) make pcvt work... it was already broken...when someone fixes pcvt to + * link properly, just rename get_pccons to xxxdevtotty and we're done + * * Revision 1.3 1995/02/25 20:08:52 pst * (a) remove the pointer to each driver's tty structure array from cdevsw * (b) add a function callback vector to tty drivers that will return a pointer @@ -53,7 +65,7 @@ static char _ittyid[] = "@(#)$Id: iitty.c,v 1.3 1995/02/25 20:08:52 pst Exp #include "gnu/isdn/isdn_ioctl.h" -int ityattach(), ityparam(); +int ityparam(); void itystart(); int nity = NITY; diff --git a/sys/gnu/isdn/isdn.c b/sys/gnu/isdn/isdn.c index e71c91b..035c4fb 100644 --- a/sys/gnu/isdn/isdn.c +++ b/sys/gnu/isdn/isdn.c @@ -1,6 +1,6 @@ -static char _isdnid[] = "@(#)$Id: isdn.c,v 1.1 1995/02/14 15:00:33 jkh Exp $"; +static char _isdnid[] = "@(#)$Id: isdn.c,v 1.2 1995/02/15 06:28:29 jkh Exp $"; /******************************************************************************* - * II - Version 0.1 $Revision: 1.1 $ $State: Exp $ + * II - Version 0.1 $Revision: 1.2 $ $State: Exp $ * * Copyright 1994 Dietmar Friede ******************************************************************************* @@ -10,6 +10,9 @@ static char _isdnid[] = "@(#)$Id: isdn.c,v 1.1 1995/02/14 15:00:33 jkh Exp $ * ******************************************************************************* * $Log: isdn.c,v $ + * Revision 1.2 1995/02/15 06:28:29 jkh + * Fix up include paths, nuke some warnings. + * * Revision 1.1 1995/02/14 15:00:33 jkh * An ISDN driver that supports the EDSS1 and the 1TR6 ISDN interfaces. * EDSS1 is the "Euro-ISDN", 1TR6 is the soon obsolete german ISDN Interface. @@ -44,6 +47,7 @@ static char _isdnid[] = "@(#)$Id: isdn.c,v 1.1 1995/02/14 15:00:33 jkh Exp $ #include "ioctl.h" #include "kernel.h" #include "systm.h" +#include "proc.h" #include "gnu/isdn/isdn_ioctl.h" @@ -51,14 +55,12 @@ isdn_appl_t isdn_appl[N_ISDN_APPL]; isdn_ctrl_t isdn_ctrl[N_ISDN_CTRL]; int Isdn_Appl, Isdn_Ctrl, Isdn_Typ; -int isdn_input(), isdn_output(); int ii_input(), ii_out(), ii_connect(), ii_disconnect(); int ity_input(), ity_out(), ity_connect(), ity_disconnect(); int itel_input(), itel_out(), itel_connect(), itel_disconnect(); int ispy_input(); int isdn_stat(); -void isdn_disconnect(); static int o_flags, r_flags, bufind[TYPNR]; static char buffer[TYPNR][257]; static u_char appl_list[TYPNR]; diff --git a/sys/gnu/isdn/isdn_ioctl.h b/sys/gnu/isdn/isdn_ioctl.h index ff49486..e0475d1 100644 --- a/sys/gnu/isdn/isdn_ioctl.h +++ b/sys/gnu/isdn/isdn_ioctl.h @@ -1,4 +1,4 @@ -static char _isdn_ioctl_id[] = "@(#)$Id: isdn_ioctl.h,v 1.1 1995/01/25 14:06:18 jkr Exp jkr $"; +static char _isdn_ioctl_id[] = "@(#)$Id: isdn_ioctl.h,v 1.1 1995/02/14 15:00:35 jkh Exp $"; /******************************************************************************* * II - Version 0.1 $Revision: 1.1 $ $State: Exp $ * @@ -10,6 +10,15 @@ static char _isdn_ioctl_id[] = "@(#)$Id: isdn_ioctl.h,v 1.1 1995/01/25 14:06 * ******************************************************************************* * $Log: isdn_ioctl.h,v $ + * Revision 1.1 1995/02/14 15:00:35 jkh + * An ISDN driver that supports the EDSS1 and the 1TR6 ISDN interfaces. + * EDSS1 is the "Euro-ISDN", 1TR6 is the soon obsolete german ISDN Interface. + * Obtained from: Dietmar Friede <dfriede@drnhh.neuhaus.de> and + * Juergen Krause <jkr@saarlink.de> + * + * This is only one part - the rest to follow in a couple of hours. + * This part is a benign import, since it doesn't affect anything else. + * * ******************************************************************************/ @@ -134,3 +143,33 @@ typedef struct #define ISDN_HANGUP _IOWR('I',4,int) #define ISDN_SET_PARAM _IOWR('I',8,isdn_param) #define ISDN_GET_PARAM _IOWR('I',9,isdn_param) + +#ifdef KERNEL + +/* XXX should be elsewhere. */ + +/* From isdn.c. */ +void isdn_accept_con_ind __P((int an, int cn, char serv, char serv_add, + char subadr, char nl, char *num)); +void isdn_conn_ind __P((int an, int cn, int dial)); +int isdn_ctrl_attach __P((int n)); +void isdn_disconn_ind __P((int an)); +void isdn_disconnect __P((int an, int rea)); +void isdn_info __P((int an, int typ, int len, char *data)); +int isdn_input __P((int an, int len, char *buf, int dir)); +int isdn_msg __P((int an)); +int isdn_output __P((int an)); + +/* From if_ii.c. */ +int iiattach __P((int ap)); + +/* From iispy.c. */ +int ispyattach __P((int ap)); + +/* From iitel.c. */ +int itelattach __P((int ap)); + +/* From iitty.c. */ +int ityattach __P((int ap)); + +#endif /* KERNEL */ |